[U-Boot] [PATCH 4/8] spi: Kconfig: Mark MXS_SPI has BROKEN

[Marek Vasut]

On 4/29/19 1:02 PM, Jagan Teki wrote:
> On Mon, Apr 29, 2019 at 4:28 PM Marek Vasut <marex at denx.de> wrote:
>>
>> On 4/29/19 12:40 PM, Jagan Teki wrote:
>>> On Mon, Apr 29, 2019 at 3:24 PM Marek Vasut <marex at denx.de> wrote:
>>>>
>>>> On 4/28/19 10:47 PM, Jagan Teki wrote:
>>>>> Mark MXS_SPI has BROKEN, this so the resulting build shows
>>>>> warning for broken configuration enabled and associated code
>>>>> will remove in v2019.07 release.
>>>>
>>>> But the code is not broken, it works fine, right ?
>>>
>>> Yes the code work fine, but dm conversion not done yet. Now the
>>> CONFIG_BROKEN can mark the driver configs which doesn't convert dm
>>
>> That makes no sense, if the code works, it works and thus it is NOT
>> broken. Find some other way to flag it as non-DM-converted, not this hack.
> 
> np, It depends on whether we consider non-dm code(for legacy SPI
> drivers) is broken or not, let Tom comment on this.

Again, the code works, it's not broken. That's very clear.
DM conversion is a separate matter, so let's not overload CONFIG_BROKEN
for such things. The Makefile warning seems sufficient to me.

-- 
Best regards,
Marek Vasut