[U-Boot] [PATCH 4/8] spi: Kconfig: Mark MXS_SPI has BROKEN

[Marek Vasut]

On 4/29/19 1:24 PM, Tom Rini wrote:
> On Mon, Apr 29, 2019 at 01:06:57PM +0200, Marek Vasut wrote:
>> On 4/29/19 1:02 PM, Jagan Teki wrote:
>>> On Mon, Apr 29, 2019 at 4:28 PM Marek Vasut <marex at denx.de> wrote:
>>>>
>>>> On 4/29/19 12:40 PM, Jagan Teki wrote:
>>>>> On Mon, Apr 29, 2019 at 3:24 PM Marek Vasut <marex at denx.de> wrote:
>>>>>>
>>>>>> On 4/28/19 10:47 PM, Jagan Teki wrote:
>>>>>>> Mark MXS_SPI has BROKEN, this so the resulting build shows
>>>>>>> warning for broken configuration enabled and associated code
>>>>>>> will remove in v2019.07 release.
>>>>>>
>>>>>> But the code is not broken, it works fine, right ?
>>>>>
>>>>> Yes the code work fine, but dm conversion not done yet. Now the
>>>>> CONFIG_BROKEN can mark the driver configs which doesn't convert dm
>>>>
>>>> That makes no sense, if the code works, it works and thus it is NOT
>>>> broken. Find some other way to flag it as non-DM-converted, not this hack.
>>>
>>> np, It depends on whether we consider non-dm code(for legacy SPI
>>> drivers) is broken or not, let Tom comment on this.
>>
>> Again, the code works, it's not broken. That's very clear.
>> DM conversion is a separate matter, so let's not overload CONFIG_BROKEN
>> for such things. The Makefile warning seems sufficient to me.
> 
> The code is broken because it doesn't work with DM and is going to be
> removed due to lack of maintenance soon.  My problem with this series,
> but I need to check that we can do what I want to do and still keep
> travis green, is have this (and the other non-converted and thus
> non-maintained drivers) depend on, not select BROKEN.
> 
> The Makefile warnings tell people the code is going to be removed and
> I'm trying to have the window be:
> 1) LOUD warning about needing work
> 2) 1 release past those loud deadlines of the code there, but not built
> unless you enable BROKEN (as yes, I see code that's not updated to use
> DM as being broken)
> 3) Code removed.
> 
> All that said, I continue to be open to delaying conversion / removal if
> we're having:
> - A discussion and proposed patches to do the conversion, but people
>   need more time.  The work is in progress, but people need time as it's
>   not as easy to convert as hoped for various reasons.
> - A problem converting the driver to DM as it's highlighting some other
>   problem within DM or hitting a size constraint or other problem.
> - Someone who is willing to do the DM work is just now seeing this.
>   Yes, this is possible especially since our LOUD Makefile warnings are
>   also easy enough to miss if you're just automating the build and not
>   doing it manually.
> 
> But I am not fine with:
> - Code that isn't converted AND
> - Code that no one seems to be converting AND
> - Code that no one says they are going to convert AND
> - The conversion deadline has past.

Seems there was some offer from Amarula to convert it , no ?

-- 
Best regards,
Marek Vasut