[U-Boot] [PATCH 1/2] i2c: mxc_i2c: Document how non-DM functions work

Heiko Schocher hs at denx.de
Tue Apr 30 04:29:30 UTC 2019

Hello Trent,

Am 16.04.2019 um 00:02 schrieb Trent Piepho:
> It is not very clear how these work in relation to the exact I2C xfers
> they produce.  In paticular, the address length is somewhat overloaded
> in the read method.  Clearly document the existing behavior.  Maybe this
> will help the next person who needs to work on this driver and not break
> non-DM boards.
> Cc: Nandor Han <nandor.han at ge.com>
> Cc: Heiko Schocher <hs at denx.de>
> Cc: Stefano Babic <sbabic at denx.de>
> Cc: Fabio Estevam <festevam at gmail.com>
> Cc: Breno Matheus Lima <brenomatheus at gmail.com>
> Signed-off-by: Trent Piepho <tpiepho at impinj.com>
> ---
>   drivers/i2c/mxc_i2c.c | 34 ++++++++++++++++++++++++++++++++++
>   1 file changed, 34 insertions(+)

Thanks, but your patch has a lot of checkpatch errors:

total: 34 errors, 0 warnings, 0 checks, 52 lines checked

please fix this and send a v2.

Reviewed-by: Heiko Schocher <hs at denx.de>

DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-52   Fax: +49-8142-66989-80   Email: hs at denx.de

More information about the U-Boot mailing list