[U-Boot] [PATCH] core: ofnode: Fix ASAN-reported stack-buffer-overflow in of_get_address

[Eugeniu Rosca]

Hi Jeremy,

Would you kindly feedback if it's possible to include commit
https://github.com/getpatchwork/patchwork/commit/67faf96ab96d932
into U-Boot's patchwork to avoid occasional glitches in the
description of U-Boot commits?

On Sun, Apr 14, 2019 at 07:39:19PM -0400, Tom Rini wrote:
> On Sun, Apr 14, 2019 at 10:13:15PM +0200, Eugeniu Rosca wrote:
> > Hi Simon,
> >  CC: Tom, Yamada-san, Jiri, Stephen,
> > 
> > On Sat, Mar 30, 2019 at 03:19:23PM -0600, Simon Glass wrote:
> > > Hi Eugeniu,
> > > 
> > > On Mon, 25 Mar 2019 at 04:44, Eugeniu Rosca <erosca at de.adit-jv.com> wrote:
> > > >
> > > > Hello Simon,
> > > >
> > > > On Sun, Mar 10, 2019 at 03:51:47PM -0600, Simon Glass wrote:
> > > > [..]
> > > > > Reviewed-by: Simon Glass <sjg at chromium.org>
> > > >
> > > > Can this fix go to u-boot-dm or is more review required?
> > > >
> > > 
> > > Yes it looks like it is in my queue.
> > > 
> > > Regards,
> > > Simon
> > 
> > First, many thanks for pushing the fix to u-boot-dm.
> > 
> > Second, I would like to (repeatedly [0]) point out a pretty rare
> > corruption of patch metadata, which places the 'Reviewed-by:'
> > (and actually any other "*-by: ") signature on top of the '====='
> > line if the latter is present in commit description (see [1]).
> > 
> > As Yamada-san pointed out in [0], this is presumably caused by a
> > patchwork bug and after some grepping through the patchwork git
> > history, it looks like the issue is already fixed in patchwork master
> > thanks to Jiri and Stephen via commit [2].
> > 
> > My guess is that the U-Boot patchwork version might not be containing
> > this recent fix, hence still showcasing the wrong behavior?
> > 
> > FWIW, at least below U-Boot commits exhibit the same inconsistency:
> > 
> > u-boot $> for c in $(git log --format=%h --grep "^======="); \
> >           do \
> >               git log --format=%B -1 $c | grep -B 2 "^=======" | \
> >               grep -q "by:.*@" && git --no-pager log --oneline -1 $c; \
> >           done
> > 
> > 0506620f4f49 sata: sata_mv: Add DM support to enable CONFIG_BLK usage
> > 9bfacf249b10 core: ofnode: Fix ASAN-reported stack-buffer-overflow in of_get_address
> > e1904f4530a3 common: avb_verify: Fix division by zero in mmc_byte_io()
> > e91610da7c8a kconfig: re-sync with Linux 4.17-rc4
> > e810565e23cd i.MX6DL: mamoj: Add PFUZE100 support
> > dda9892171c3 i.MX6DL: mamoj: Add I2C support
> > a0b0ff0ae643 arm: dra7xx: Fix Linux boot from eMMC
> > f6d245b8c56c arm: am57xx: Fix Linux boot from eMMC
> > 67ff9e11f397 wandboard: move environment partition farther from u-boot.img
> > 
> > [0] https://marc.info/?l=u-boot&m=152643616902958&w=2
> > [1] http://git.denx.de/?p=u-boot.git;a=commitdiff;h=9bfacf249b10
> > [2] https://github.com/getpatchwork/patchwork/commit/67faf96ab96d932
> >     ("parser: fix parsing of patches with headings")
> 
> Adding in Jeremy since we just use the ozlabs patchwork, thanks!
> 
> -- 
> Tom

-- 
Best Regards,
Eugeniu.