[U-Boot] [PATCH v7 3/9] x86: Add a common HOB library

Bin Meng bmeng.cn at gmail.com
Thu Aug 1 06:00:34 UTC 2019


Hi Aiden,

On Mon, Jul 29, 2019 at 12:35 PM Park, Aiden <aiden.park at intel.com> wrote:
>
> FSP(CONFIG_HAVE_FSP) and Slim Bootloader(CONFIG_SYS_SLIMBOOTLOADER)
> consume HOB(CONFIG_USE_HOB) data from the each HOB list pointer.
> Add a common HOB library in lib/hob.c and include/asm/hob.h.
>
> Signed-off-by: Aiden Park <aiden.park at intel.com>
> ---
>
> Changes in v7:
>   * Split HOB library into EFI_GUID pre-work and making a common library
>
> Changes in v6:
>   * Use CONFIG_USE_HOB
>   * Change struct efi_guid to efi_guid_t
>   * Use EFI_GUID to define GUIDs
>
> Changes in v3:
>   * Create a common HOB libary from fsp_hob and fsp_support
>
>  arch/x86/include/asm/fsp/fsp_hob.h     | 184 +-------------------
>  arch/x86/include/asm/fsp/fsp_support.h |  37 +---
>  arch/x86/include/asm/hob.h             | 229 +++++++++++++++++++++++++
>  arch/x86/lib/Makefile                  |   1 +
>  arch/x86/lib/fsp/fsp_support.c         |  57 +-----
>  arch/x86/lib/hob.c                     |  84 +++++++++
>  cmd/x86/Makefile                       |   1 +
>  cmd/x86/fsp.c                          |  65 +------
>  cmd/x86/hob.c                          |  78 +++++++++

It looks that you did not use "git format-patch -M" to detect file
rename? Or you can use patman to help the patch generation.

>  9 files changed, 399 insertions(+), 337 deletions(-)
>  create mode 100644 arch/x86/include/asm/hob.h
>  create mode 100644 arch/x86/lib/hob.c
>  create mode 100644 cmd/x86/hob.c
>

Reviewed-by: Bin Meng <bmeng.cn at gmail.com>
Tested-by: Bin Meng <bmeng.cn at gmail.com>

Regards,
Bin


More information about the U-Boot mailing list