[U-Boot] [PATCH v7 3/9] x86: Add a common HOB library

[Park, Aiden]

Hi Bin/Andy,

> -----Original Message-----
> From: Andy Shevchenko [mailto:andy.shevchenko at gmail.com]
> Sent: Thursday, August 1, 2019 5:14 PM
> To: Bin Meng <bmeng.cn at gmail.com>
> Cc: Park, Aiden <aiden.park at intel.com>; U-Boot Mailing List <u-
> boot at lists.denx.de>; Simon Glass <sjg at chromium.org>
> Subject: Re: [PATCH v7 3/9] x86: Add a common HOB library
> 
> On Thu, Aug 1, 2019 at 9:00 AM Bin Meng <bmeng.cn at gmail.com> wrote:
> > On Mon, Jul 29, 2019 at 12:35 PM Park, Aiden <aiden.park at intel.com>
> wrote:
> 
> > >  arch/x86/include/asm/fsp/fsp_hob.h     | 184 +-------------------
> > >  arch/x86/include/asm/fsp/fsp_support.h |  37 +---
> > >  arch/x86/include/asm/hob.h             | 229
> +++++++++++++++++++++++++
> > >  arch/x86/lib/Makefile                  |   1 +
> > >  arch/x86/lib/fsp/fsp_support.c         |  57 +-----
> > >  arch/x86/lib/hob.c                     |  84 +++++++++
> > >  cmd/x86/Makefile                       |   1 +
> > >  cmd/x86/fsp.c                          |  65 +------
> > >  cmd/x86/hob.c                          |  78 +++++++++
> >
> > It looks that you did not use "git format-patch -M" to detect file
> > rename? Or you can use patman to help the patch generation.
> 
> It looks like not only rename, thus '-M -C' would play better.
> 
Thanks you for pointing it out. Let me use the options to generate patches.

> --
> With Best Regards,
> Andy Shevchenko

Best Regards,
Aiden