[U-Boot] [PATCH 1/2] console: update silent tag after env load

Patrice Chotard patrice.chotard at st.com
Fri Aug 2 12:58:09 UTC 2019


From: Patrick Delaunay <patrick.delaunay at st.com>

Update the "silent" property with the variable "silent" get from
saved environment, it solves the issue when:
- CONFIG_SILENT_CONSOLE and CONFIG_SYS_CONSOLE_IS_IN_ENV are activated
- silent is not defined in default environment
- silent is requested in saved environment with:
  > env set silent 1; env save

On next reboot the console is not disabled as expected after relocation
and the environment load from flash (the callback is not called when
the INSERT is requested in the created hash table)

Signed-off-by: Patrick Delaunay <patrick.delaunay at st.com>
Signed-off-by: Patrice Chotard <patrice.chotard at st.com>
---

 common/console.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/common/console.c b/common/console.c
index 0b0dd76256..7b45403bb3 100644
--- a/common/console.c
+++ b/common/console.c
@@ -793,6 +793,9 @@ int console_init_r(void)
 	int iomux_err = 0;
 #endif
 
+	/* update silent for env loaded from flash (initr_env) */
+	console_update_silent();
+
 	/* set default handlers at first */
 	gd->jt->getc  = serial_getc;
 	gd->jt->tstc  = serial_tstc;
@@ -884,6 +887,7 @@ int console_init_r(void)
 	struct list_head *pos;
 	struct stdio_dev *dev;
 
+	/* update silent for env loaded from flash (initr_env) */
 	console_update_silent();
 
 #ifdef CONFIG_SPLASH_SCREEN
-- 
2.17.1



More information about the U-Boot mailing list