[U-Boot] [PATCH] fit: Do not automatically decompress ramdisk images

Heiko Schocher hs at denx.de
Mon Aug 5 05:21:53 UTC 2019


Hello Julius,

Am 03.08.2019 um 00:52 schrieb Julius Werner:
> The Linux ramdisk should always be decompressed by the kernel itself,
> not by U-Boot. Therefore, the 'compression' node in the FIT image should
> always be set to "none" for ramdisk images, since the only point of
> using that node is if you want U-Boot to do the decompression itself.
> 
> Yet some systems populate the node to the compression algorithm used by
> the kernel instead. This used to be ignored, but now that we support
> decompression of all image types it becomes a problem. Since ramdisks
> should never be decompressed by U-Boot anyway, this patch adds a special
> exception for them to avoid these issues. Still, setting the
> 'compression' node like that is wrong in the first place, so we still
> want to print out a warning so that third-party distributions doing this
> can notice and fix it.
> 
> Signed-off-by: Julius Werner <jwerner at chromium.org>
> ---
>   common/image-fit.c        | 13 +++++++++----
>   test/py/tests/test_fit.py | 10 +++++++++-
>   2 files changed, 18 insertions(+), 5 deletions(-)

Many thanks!

Reviewed-by: Heiko Schocher <hs at denx.de>
Tested-by: Heiko Schocher <hs at denx.de>

bye,
Heiko
-- 
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-52   Fax: +49-8142-66989-80   Email: hs at denx.de


More information about the U-Boot mailing list