[U-Boot] [PATCH v3 13/18] usb: dwc3: Kconfig: get rid of obsolete mode selection
jjhiblot at ti.com
Wed Aug 7 15:59:52 UTC 2019
On 07/08/2019 14:06, Marek Vasut wrote:
> On 6/27/19 1:02 PM, Jean-Jacques Hiblot wrote:
>> The mode selection for the DWC3 is kind of obsolete. The driver does not
>> have to be host only or gadget only. This choice is confusing.
>> All the remaining callers of dwc3_uboot_init() explicitly set dr_mode
>> before calling the function, so none rely on a default behavior.
>> Remove the choice menu and keep only the USB_DWC3_GADGET option. Enable it
>> by default if USB_GADGET and USB_DWC3 are enabled.
>> It must be disabled for the evb-rk3328 as it uses DWC2 for the gadget and
>> DWC3 for the host.
>> Signed-off-by: Jean-Jacques Hiblot <jjhiblot at ti.com>
> This patch breaks u-boot-usb/master and makes it not build e.g. on
> odroid-n2 , I am dropping it.
I've just send a fix for this that applies on top of u-boot-usb/master.
Leaving this patch out, breaks the build of the k2g-evm platform.
The odroid-n2 is using DWC3 for host and DWC2 for the peripheral. This
requires tweaking the defconfig to override the default behavior which
is 'if gadget enabled and dwc3 present, then enable dwc3 gadget'
More information about the U-Boot