[U-Boot] [PATCH] riscv: qemu: Fix kconfig build warning

Bin Meng bmeng.cn at gmail.com
Thu Aug 8 06:50:58 UTC 2019


Hi Rick,

On Thu, Aug 8, 2019 at 2:49 PM Rick Chen <rickchen36 at gmail.com> wrote:
>
> Hi Bin
>
> > > From: Bin Meng [mailto:bmeng.cn at gmail.com]
> > > Sent: Thursday, August 08, 2019 2:05 PM
> > > To: Lukas Auer; Rick Jian-Zhi Chen(陳建志); U-Boot Mailing List
> > > Subject: [PATCH] riscv: qemu: Fix kconfig build warning
> > >
> > > When 'make qemu-riscv64_defconfig', there is a build warning:
> > >
> > >   board/emulation/qemu-riscv/Kconfig:24:
> > >   warning: config symbol defined without type
> > >
> > > Fix it by specifying the config symbol type to 'hex'.
> > >
> > > Signed-off-by: Bin Meng <bmeng.cn at gmail.com>
> > > ---
> > >
> > >  board/emulation/qemu-riscv/Kconfig | 1 +
> > >  1 file changed, 1 insertion(+)
> > >
> > > diff --git a/board/emulation/qemu-riscv/Kconfig
> > > b/board/emulation/qemu-riscv/Kconfig
> > > index 1928d6d..7ce1201 100644
> > > --- a/board/emulation/qemu-riscv/Kconfig
> > > +++ b/board/emulation/qemu-riscv/Kconfig
> > > @@ -22,6 +22,7 @@ config SPL_TEXT_BASE
> > >       default 0x80000000
> > >
> > >  config SPL_OPENSBI_LOAD_ADDR
> > > +     hex
> > >       default 0x81000000
> > >
> > >  config BOARD_SPECIFIC_OPTIONS # dummy
> > > --
> > > 2.7.4
> >
>
> Good catch!
>
> But I am wondering why SPL_TEXT_BASE will not have the same warning message?
> They are declared  the same way.
> Do you know why ?
>

Because SPL_TEXT_BASE has a type defined in common/spl/Kconfig hence
Kconfig knows its type.

> Reviewed-by: Rick Chen <rick at andestech.com>

Regards,
Bin


More information about the U-Boot mailing list