[U-Boot] [PATCH 4/4] clk: imx: add i.MX8MM clk driver

Peng Fan peng.fan at nxp.com
Thu Aug 8 07:09:12 UTC 2019


Hi Lukasz,

> Subject: Re: [PATCH 4/4] clk: imx: add i.MX8MM clk driver
> 
> On Tue, 6 Aug 2019 10:03:11 +0000
> Peng Fan <peng.fan at nxp.com> wrote:
> 
> > Add i.MX8MM clk driver support.
> >
> > Signed-off-by: Peng Fan <peng.fan at nxp.com>
> > ---
> >  drivers/clk/imx/Makefile     |   2 +
> >  drivers/clk/imx/clk-imx8mm.c | 414
> > +++++++++++++++++++++++++++++++++++++++++++ 2 files changed, 416
> > insertions(+) create mode 100644 drivers/clk/imx/clk-imx8mm.c
> >
> > diff --git a/drivers/clk/imx/Makefile b/drivers/clk/imx/Makefile index
> > 105a58ca90..5ad7967fe9 100644
> > --- a/drivers/clk/imx/Makefile
> > +++ b/drivers/clk/imx/Makefile
> > @@ -10,3 +10,5 @@ ifdef CONFIG_CLK_IMX8
> >  obj-$(CONFIG_IMX8QXP) += clk-imx8qxp.o
> >  obj-$(CONFIG_IMX8QM) += clk-imx8qm.o
> >  endif
> > +obj-$(CONFIG_$(SPL_TPL_)CLK_IMX8MM) += clk-imx8mm.o clk-pll14xx.o
> \
> > +				clk-composite-8m.o
> > diff --git a/drivers/clk/imx/clk-imx8mm.c
> > b/drivers/clk/imx/clk-imx8mm.c new file mode 100644 index
> > 0000000000..9459d8ab8e
> > --- /dev/null
> > +++ b/drivers/clk/imx/clk-imx8mm.c
> > @@ -0,0 +1,414 @@
> > +// SPDX-License-Identifier: GPL-2.0
> > +/*
> > + * Copyright 2019 NXP
> > + * Peng Fan <peng.fan at nxp.com>
> > + */
> > +
> > +#include <common.h>
> > +#include <clk.h>
> > +#include <clk-uclass.h>
> > +#include <dm.h>
> > +#include <asm/arch/clock.h>
> > +#include <asm/arch/imx-regs.h>
> > +#include <dt-bindings/clock/imx8mm-clock.h>
> > +
> > +#include "clk.h"
> > +
> > +#define PLL_1416X_RATE(_rate, _m, _p, _s)		\
> > +	{						\
> > +		.rate	=	(_rate),		\
> > +		.mdiv	=	(_m),			\
> > +		.pdiv	=	(_p),			\
> > +		.sdiv	=	(_s),			\
> > +	}
> > +
> > +#define PLL_1443X_RATE(_rate, _m, _p, _s, _k)		\
> > +	{						\
> > +		.rate	=	(_rate),		\
> > +		.mdiv	=	(_m),			\
> > +		.pdiv	=	(_p),			\
> > +		.sdiv	=	(_s),			\
> > +		.kdiv	=	(_k),			\
> > +	}
> > +
> > +static const struct imx_pll14xx_rate_table imx8mm_pll1416x_tbl[] = {
> > +	PLL_1416X_RATE(1800000000U, 225, 3, 0),
> > +	PLL_1416X_RATE(1600000000U, 200, 3, 0),
> > +	PLL_1416X_RATE(1200000000U, 300, 3, 1),
> > +	PLL_1416X_RATE(1000000000U, 250, 3, 1),
> > +	PLL_1416X_RATE(800000000U,  200, 3, 1),
> > +	PLL_1416X_RATE(750000000U,  250, 2, 2),
> > +	PLL_1416X_RATE(700000000U,  350, 3, 2),
> > +	PLL_1416X_RATE(600000000U,  300, 3, 2), };
> > +
> > +static const struct imx_pll14xx_rate_table imx8mm_drampll_tbl[] = {
> > +	PLL_1443X_RATE(650000000U, 325, 3, 2, 0), };
> > +
> > +static struct imx_pll14xx_clk imx8mm_dram_pll __initdata = {
> > +		.type = PLL_1443X,
> > +		.rate_table = imx8mm_drampll_tbl,
> > +		.rate_count = ARRAY_SIZE(imx8mm_drampll_tbl), };
> > +
> > +static struct imx_pll14xx_clk imx8mm_arm_pll __initdata = {
> > +		.type = PLL_1416X,
> > +		.rate_table = imx8mm_pll1416x_tbl,
> > +		.rate_count = ARRAY_SIZE(imx8mm_pll1416x_tbl), };
> > +
> > +static struct imx_pll14xx_clk imx8mm_sys_pll __initdata = {
> > +		.type = PLL_1416X,
> > +		.rate_table = imx8mm_pll1416x_tbl,
> > +		.rate_count = ARRAY_SIZE(imx8mm_pll1416x_tbl), };
> > +
> > +static const char *pll_ref_sels[] = { "clock-osc-24m", "dummy",
> > "dummy", "dummy", }; +static const char *dram_pll_bypass_sels[] =
> > {"dram_pll", "dram_pll_ref_sel", }; +static const char
> > *arm_pll_bypass_sels[] = {"arm_pll", "arm_pll_ref_sel", }; +static
> > const char *sys_pll1_bypass_sels[] = {"sys_pll1", "sys_pll1_ref_sel",
> > }; +static const char *sys_pll2_bypass_sels[] = {"sys_pll2",
> > "sys_pll2_ref_sel", }; +static const char *sys_pll3_bypass_sels[] =
> > {"sys_pll3", "sys_pll3_ref_sel", }; + +static const char
> > *imx8mm_a53_sels[] = {"clock-osc-24m", "arm_pll_out", "sys_pll2_500m",
> > "sys_pll2_1000m",
> > +					"sys_pll1_800m",
> > "sys_pll1_400m", "audio_pll1_out", "sys_pll3_out", }; +
> > +static const char *imx8mm_ahb_sels[] = {"osc_24m", "sys_pll1_133m",
> > "sys_pll1_800m", "sys_pll1_400m",
> > +					"sys_pll2_125m",
> > "sys_pll3_out", "audio_pll1_out", "video_pll1_out", }; +
> > +static const char *imx8mm_enet_axi_sels[] = {"clock-osc-24m",
> > "sys_pll1_266m", "sys_pll1_800m", "sys_pll2_250m",
> > +					     "sys_pll2_200m",
> > "audio_pll1_out", "video_pll1_out", "sys_pll3_out", }; +
> > +static const char *imx8mm_nand_usdhc_sels[] = {"clock-osc-24m",
> > "sys_pll1_266m", "sys_pll1_800m", "sys_pll2_200m",
> > +					       "sys_pll1_133m",
> > "sys_pll3_out", "sys_pll2_250m", "audio_pll1_out", }; +
> > +static const char *imx8mm_usdhc1_sels[] = {"clock-osc-24m",
> > "sys_pll1_400m", "sys_pll1_800m", "sys_pll2_500m",
> > +					   "sys_pll3_out",
> > "sys_pll1_266m", "audio_pll2_out", "sys_pll1_100m", }; +
> > +static const char *imx8mm_usdhc2_sels[] = {"clock-osc-24m",
> > "sys_pll1_400m", "sys_pll1_800m", "sys_pll2_500m",
> > +					   "sys_pll3_out",
> > "sys_pll1_266m", "audio_pll2_out", "sys_pll1_100m", }; +
> > +static const char *imx8mm_i2c1_sels[] = {"clock-osc-24m",
> > "sys_pll1_160m", "sys_pll2_50m", "sys_pll3_out", "audio_pll1_out",
> > +					 "video_pll1_out",
> > "audio_pll2_out", "sys_pll1_133m", }; +
> > +static const char *imx8mm_i2c2_sels[] = {"clock-osc-24m",
> > "sys_pll1_160m", "sys_pll2_50m", "sys_pll3_out", "audio_pll1_out",
> > +					 "video_pll1_out",
> > "audio_pll2_out", "sys_pll1_133m", }; +
> > +static const char *imx8mm_i2c3_sels[] = {"clock-osc-24m",
> > "sys_pll1_160m", "sys_pll2_50m", "sys_pll3_out", "audio_pll1_out",
> > +					 "video_pll1_out",
> > "audio_pll2_out", "sys_pll1_133m", }; +
> > +static const char *imx8mm_i2c4_sels[] = {"clock-osc-24m",
> > "sys_pll1_160m", "sys_pll2_50m", "sys_pll3_out", "audio_pll1_out",
> > +					 "video_pll1_out",
> > "audio_pll2_out", "sys_pll1_133m", }; +
> > +static const char *imx8mm_wdog_sels[] = {"clock-osc-24m",
> > "sys_pll1_133m", "sys_pll1_160m", "vpu_pll_out",
> > +					 "sys_pll2_125m",
> > "sys_pll3_out", "sys_pll1_80m", "sys_pll2_166m", }; +
> > +static const char *imx8mm_usdhc3_sels[] = {"clock-osc-24m",
> > "sys_pll1_400m", "sys_pll1_800m", "sys_pll2_500m",
> > +					   "sys_pll3_out",
> > "sys_pll1_266m", "audio_pll2_clk", "sys_pll1_100m", }; +
> > +static ulong imx8mm_clk_get_rate(struct clk *clk) {
> > +	struct clk *c;
> > +	int ret;
> > +
> > +	debug("%s(#%lu)\n", __func__, clk->id);
> > +
> > +	ret = clk_get_by_id(clk->id, &c);
> > +	if (ret)
> > +		return ret;
> > +
> > +	return clk_get_rate(c);
> > +}
> > +
> > +static ulong imx8mm_clk_set_rate(struct clk *clk, unsigned long rate)
> > +{
> > +	struct clk *c;
> > +	int ret = 0;
> > +
> > +	debug("%s(#%lu), rate: %lu\n", __func__, clk->id, rate);
> > +
> > +	ret = clk_get_by_id(clk->id, &c);
> > +	if (ret)
> > +		return ret;
> > +
> > +	return clk_set_rate(c, rate);
> > +}
> > +
> > +static int __imx8mm_clk_enable(struct clk *clk, bool enable) {
> > +	struct clk *c;
> > +	int ret = 0;
> > +
> > +	debug("%s(#%lu) en: %d\n", __func__, clk->id, enable);
> > +
> > +	ret = clk_get_by_id(clk->id, &c);
> > +	if (ret)
> > +		return ret;
> > +
> > +	if (enable)
> > +		ret = clk_enable(c);
> > +	else
> > +		ret = clk_disable(c);
> > +
> > +	return ret;
> > +}
> > +
> > +static int imx8mm_clk_disable(struct clk *clk) {
> > +	return __imx8mm_clk_enable(clk, 0);
> > +}
> > +
> > +static int imx8mm_clk_enable(struct clk *clk) {
> > +	return __imx8mm_clk_enable(clk, 1);
> > +}
> > +
> > +static struct clk_ops imx8mm_clk_ops = {
> > +	.set_rate = imx8mm_clk_set_rate,
> > +	.get_rate = imx8mm_clk_get_rate,
> > +	.enable = imx8mm_clk_enable,
> > +	.disable = imx8mm_clk_disable,
> > +};
> > +
> > +static int imx8mm_clk_probe(struct udevice *dev) {
> > +	void __iomem *base;
> > +
> > +	base = (void *)ANATOP_BASE_ADDR;
> > +
> > +	clk_dm(IMX8MM_DRAM_PLL_REF_SEL,
> > +	       imx_clk_mux("dram_pll_ref_sel", base + 0x50, 0, 2,
> > +			   pll_ref_sels, ARRAY_SIZE(pll_ref_sels)));
> > +	clk_dm(IMX8MM_ARM_PLL_REF_SEL,
> > +	       imx_clk_mux("arm_pll_ref_sel", base + 0x84, 0, 2,
> > +			   pll_ref_sels, ARRAY_SIZE(pll_ref_sels)));
> > +	clk_dm(IMX8MM_SYS_PLL1_REF_SEL,
> > +	       imx_clk_mux("sys_pll1_ref_sel", base + 0x94, 0, 2,
> > +			   pll_ref_sels, ARRAY_SIZE(pll_ref_sels)));
> > +	clk_dm(IMX8MM_SYS_PLL2_REF_SEL,
> > +	       imx_clk_mux("sys_pll2_ref_sel", base + 0x104, 0, 2,
> > +			   pll_ref_sels, ARRAY_SIZE(pll_ref_sels)));
> > +	clk_dm(IMX8MM_SYS_PLL3_REF_SEL,
> > +	       imx_clk_mux("sys_pll3_ref_sel", base + 0x114, 0, 2,
> > +			   pll_ref_sels, ARRAY_SIZE(pll_ref_sels)));
> > +
> > +	clk_dm(IMX8MM_DRAM_PLL,
> > +	       imx_clk_pll14xx("dram_pll", "dram_pll_ref_sel",
> > +			       base + 0x50, &imx8mm_dram_pll));
> > +	clk_dm(IMX8MM_ARM_PLL,
> > +	       imx_clk_pll14xx("arm_pll", "arm_pll_ref_sel",
> > +			       base + 0x84, &imx8mm_arm_pll));
> > +	clk_dm(IMX8MM_SYS_PLL1,
> > +	       imx_clk_pll14xx("sys_pll1", "sys_pll1_ref_sel",
> > +			       base + 0x94, &imx8mm_sys_pll));
> > +	clk_dm(IMX8MM_SYS_PLL2,
> > +	       imx_clk_pll14xx("sys_pll2", "sys_pll2_ref_sel",
> > +			       base + 0x104, &imx8mm_sys_pll));
> > +	clk_dm(IMX8MM_SYS_PLL3,
> > +	       imx_clk_pll14xx("sys_pll3", "sys_pll3_ref_sel",
> > +			       base + 0x114, &imx8mm_sys_pll));
> > +
> > +	/* PLL bypass out */
> > +	clk_dm(IMX8MM_DRAM_PLL_BYPASS,
> > +	       imx_clk_mux_flags("dram_pll_bypass", base + 0x50, 4,
> > 1,
> > +				 dram_pll_bypass_sels,
> > +				 ARRAY_SIZE(dram_pll_bypass_sels),
> > +				 CLK_SET_RATE_PARENT));
> > +	clk_dm(IMX8MM_ARM_PLL_BYPASS,
> > +	       imx_clk_mux_flags("arm_pll_bypass", base + 0x84, 4, 1,
> > +				 arm_pll_bypass_sels,
> > +				 ARRAY_SIZE(arm_pll_bypass_sels),
> > +				 CLK_SET_RATE_PARENT));
> > +	clk_dm(IMX8MM_SYS_PLL1_BYPASS,
> > +	       imx_clk_mux_flags("sys_pll1_bypass", base + 0x94, 4,
> > 1,
> > +				 sys_pll1_bypass_sels,
> > +				 ARRAY_SIZE(sys_pll1_bypass_sels),
> > +				 CLK_SET_RATE_PARENT));
> > +	clk_dm(IMX8MM_SYS_PLL2_BYPASS,
> > +	       imx_clk_mux_flags("sys_pll2_bypass", base + 0x104, 4,
> > 1,
> > +				 sys_pll2_bypass_sels,
> > +				 ARRAY_SIZE(sys_pll2_bypass_sels),
> > +				 CLK_SET_RATE_PARENT));
> > +	clk_dm(IMX8MM_SYS_PLL3_BYPASS,
> > +	       imx_clk_mux_flags("sys_pll3_bypass", base + 0x114, 4,
> > 1,
> > +				 sys_pll3_bypass_sels,
> > +				 ARRAY_SIZE(sys_pll3_bypass_sels),
> > +				 CLK_SET_RATE_PARENT));
> > +
> > +	/* PLL out gate */
> > +	clk_dm(IMX8MM_DRAM_PLL_OUT,
> > +	       imx_clk_gate("dram_pll_out", "dram_pll_bypass",
> > +			    base + 0x50, 13));
> > +	clk_dm(IMX8MM_ARM_PLL_OUT,
> > +	       imx_clk_gate("arm_pll_out", "arm_pll_bypass",
> > +			    base + 0x84, 13));
> > +	clk_dm(IMX8MM_SYS_PLL1_OUT,
> > +	       imx_clk_gate("sys_pll1_out", "sys_pll1_bypass",
> > +			    base + 0x94, 13));
> > +	clk_dm(IMX8MM_SYS_PLL2_OUT,
> > +	       imx_clk_gate("sys_pll2_out", "sys_pll2_bypass",
> > +			    base + 0x104, 13));
> > +	clk_dm(IMX8MM_SYS_PLL3_OUT,
> > +	       imx_clk_gate("sys_pll3_out", "sys_pll3_bypass",
> > +			    base + 0x114, 13));
> > +
> > +	/* SYS PLL fixed output */
> > +	clk_dm(IMX8MM_SYS_PLL1_40M,
> > +	       imx_clk_fixed_factor("sys_pll1_40m", "sys_pll1_out",
> > 1, 20));
> > +	clk_dm(IMX8MM_SYS_PLL1_80M,
> > +	       imx_clk_fixed_factor("sys_pll1_80m", "sys_pll1_out",
> > 1, 10));
> > +	clk_dm(IMX8MM_SYS_PLL1_100M,
> > +	       imx_clk_fixed_factor("sys_pll1_100m", "sys_pll1_out",
> > 1, 8));
> > +	clk_dm(IMX8MM_SYS_PLL1_133M,
> > +	       imx_clk_fixed_factor("sys_pll1_133m", "sys_pll1_out",
> > 1, 6));
> > +	clk_dm(IMX8MM_SYS_PLL1_160M,
> > +	       imx_clk_fixed_factor("sys_pll1_160m", "sys_pll1_out",
> > 1, 5));
> > +	clk_dm(IMX8MM_SYS_PLL1_200M,
> > +	       imx_clk_fixed_factor("sys_pll1_200m", "sys_pll1_out",
> > 1, 4));
> > +	clk_dm(IMX8MM_SYS_PLL1_266M,
> > +	       imx_clk_fixed_factor("sys_pll1_266m", "sys_pll1_out",
> > 1, 3));
> > +	clk_dm(IMX8MM_SYS_PLL1_400M,
> > +	       imx_clk_fixed_factor("sys_pll1_400m", "sys_pll1_out",
> > 1, 2));
> > +	clk_dm(IMX8MM_SYS_PLL1_800M,
> > +	       imx_clk_fixed_factor("sys_pll1_800m", "sys_pll1_out",
> > 1, 1)); +
> > +	clk_dm(IMX8MM_SYS_PLL2_50M,
> > +	       imx_clk_fixed_factor("sys_pll2_50m", "sys_pll2_out",
> > 1, 20));
> > +	clk_dm(IMX8MM_SYS_PLL2_100M,
> > +	       imx_clk_fixed_factor("sys_pll2_100m", "sys_pll2_out",
> > 1, 10));
> > +	clk_dm(IMX8MM_SYS_PLL2_125M,
> > +	       imx_clk_fixed_factor("sys_pll2_125m", "sys_pll2_out",
> > 1, 8));
> > +	clk_dm(IMX8MM_SYS_PLL2_166M,
> > +	       imx_clk_fixed_factor("sys_pll2_166m", "sys_pll2_out",
> > 1, 6));
> > +	clk_dm(IMX8MM_SYS_PLL2_200M,
> > +	       imx_clk_fixed_factor("sys_pll2_200m", "sys_pll2_out",
> > 1, 5));
> > +	clk_dm(IMX8MM_SYS_PLL2_250M,
> > +	       imx_clk_fixed_factor("sys_pll2_250m", "sys_pll2_out",
> > 1, 4));
> > +	clk_dm(IMX8MM_SYS_PLL2_333M,
> > +	       imx_clk_fixed_factor("sys_pll2_333m", "sys_pll2_out",
> > 1, 3));
> > +	clk_dm(IMX8MM_SYS_PLL2_500M,
> > +	       imx_clk_fixed_factor("sys_pll2_500m", "sys_pll2_out",
> > 1, 2));
> > +	clk_dm(IMX8MM_SYS_PLL2_1000M,
> > +	       imx_clk_fixed_factor("sys_pll2_1000m",
> > "sys_pll2_out", 1, 1)); +
> > +	base = dev_read_addr_ptr(dev);
> > +	if (base == (void *)FDT_ADDR_T_NONE)
> > +		return -EINVAL;
> > +
> > +	clk_dm(IMX8MM_CLK_A53_SRC,
> > +	       imx_clk_mux2("arm_a53_src", base + 0x8000, 24, 3,
> > +			    imx8mm_a53_sels,
> > ARRAY_SIZE(imx8mm_a53_sels)));
> > +	clk_dm(IMX8MM_CLK_A53_CG,
> > +	       imx_clk_gate3("arm_a53_cg", "arm_a53_src", base +
> > 0x8000, 28));
> > +	clk_dm(IMX8MM_CLK_A53_DIV,
> > +	       imx_clk_divider2("arm_a53_div", "arm_a53_cg",
> > +				base + 0x8000, 0, 3));
> > +
> > +	clk_dm(IMX8MM_CLK_AHB,
> > +	       imx8m_clk_composite_critical("ahb", imx8mm_ahb_sels,
> > +					    base + 0x9000));
> > +	clk_dm(IMX8MM_CLK_IPG_ROOT,
> > +	       imx_clk_divider2("ipg_root", "ahb", base + 0x9080, 0,
> > 1)); +
> > +	clk_dm(IMX8MM_CLK_ENET_AXI,
> > +	       imx8m_clk_composite("enet_axi", imx8mm_enet_axi_sels,
> > +				   base + 0x8880));
> > +	clk_dm(IMX8MM_CLK_NAND_USDHC_BUS,
> > +	       imx8m_clk_composite_critical("nand_usdhc_bus",
> > +					    imx8mm_nand_usdhc_sels,
> > +					    base + 0x8900));
> > +
> > +	/* IP */
> > +	clk_dm(IMX8MM_CLK_USDHC1,
> > +	       imx8m_clk_composite("usdhc1", imx8mm_usdhc1_sels,
> > +				   base + 0xac00));
> > +	clk_dm(IMX8MM_CLK_USDHC2,
> > +	       imx8m_clk_composite("usdhc2", imx8mm_usdhc2_sels,
> > +				   base + 0xac80));
> > +	clk_dm(IMX8MM_CLK_I2C1,
> > +	       imx8m_clk_composite("i2c1", imx8mm_i2c1_sels, base +
> > 0xad00));
> > +	clk_dm(IMX8MM_CLK_I2C2,
> > +	       imx8m_clk_composite("i2c2", imx8mm_i2c2_sels, base +
> > 0xad80));
> > +	clk_dm(IMX8MM_CLK_I2C3,
> > +	       imx8m_clk_composite("i2c3", imx8mm_i2c3_sels, base +
> > 0xae00));
> > +	clk_dm(IMX8MM_CLK_I2C4,
> > +	       imx8m_clk_composite("i2c4", imx8mm_i2c4_sels, base +
> > 0xae80));
> > +	clk_dm(IMX8MM_CLK_WDOG,
> > +	       imx8m_clk_composite("wdog", imx8mm_wdog_sels, base +
> > 0xb900));
> > +	clk_dm(IMX8MM_CLK_USDHC3,
> > +	       imx8m_clk_composite("usdhc3", imx8mm_usdhc3_sels,
> > +				   base + 0xbc80));
> > +
> > +	clk_dm(IMX8MM_CLK_I2C1_ROOT,
> > +	       imx_clk_gate4("i2c1_root_clk", "i2c1", base + 0x4170,
> > 0));
> > +	clk_dm(IMX8MM_CLK_I2C2_ROOT,
> > +	       imx_clk_gate4("i2c2_root_clk", "i2c2", base + 0x4180,
> > 0));
> > +	clk_dm(IMX8MM_CLK_I2C3_ROOT,
> > +	       imx_clk_gate4("i2c3_root_clk", "i2c3", base + 0x4190,
> > 0));
> > +	clk_dm(IMX8MM_CLK_I2C4_ROOT,
> > +	       imx_clk_gate4("i2c4_root_clk", "i2c4", base + 0x41a0,
> > 0));
> > +	clk_dm(IMX8MM_CLK_OCOTP_ROOT,
> > +	       imx_clk_gate4("ocotp_root_clk", "ipg_root", base +
> > 0x4220, 0));
> > +	clk_dm(IMX8MM_CLK_USDHC1_ROOT,
> > +	       imx_clk_gate4("usdhc1_root_clk", "usdhc1", base +
> > 0x4510, 0));
> > +	clk_dm(IMX8MM_CLK_USDHC2_ROOT,
> > +	       imx_clk_gate4("usdhc2_root_clk", "usdhc2", base +
> > 0x4520, 0));
> > +	clk_dm(IMX8MM_CLK_WDOG1_ROOT,
> > +	       imx_clk_gate4("wdog1_root_clk", "wdog", base +
> > 0x4530, 0));
> > +	clk_dm(IMX8MM_CLK_WDOG2_ROOT,
> > +	       imx_clk_gate4("wdog2_root_clk", "wdog", base +
> > 0x4540, 0));
> > +	clk_dm(IMX8MM_CLK_WDOG3_ROOT,
> > +	       imx_clk_gate4("wdog3_root_clk", "wdog", base +
> > 0x4550, 0));
> > +	clk_dm(IMX8MM_CLK_USDHC3_ROOT,
> > +	       imx_clk_gate4("usdhc3_root_clk", "usdhc3", base +
> > 0x45e0, 0)); +
> > +#ifdef CONFIG_SPL_BUILD
> > +	struct clk *clkp, *clkp1;
> > +	struct udevice *devp;
> > +
> > +	clk_get_by_id(IMX8MM_CLK_WDOG1_ROOT, &clkp);
> > +	clk_enable(clkp);
> > +	clk_get_by_id(IMX8MM_CLK_WDOG2_ROOT, &clkp);
> > +	clk_enable(clkp);
> > +	clk_get_by_id(IMX8MM_CLK_WDOG3_ROOT, &clkp);
> > +	clk_enable(clkp);
> > +
> > +	/* Configure SYS_PLL3 to 750MHz */
> > +	clk_get_by_id(IMX8MM_SYS_PLL3, &clkp);
> > +	clk_set_rate(clkp, 750000000UL);
> > +
> > +	/* Configure ARM to osc24M */
> > +	clk_get_by_id(IMX8MM_CLK_A53_SRC, &clkp);
> > +	uclass_get_device_by_name(UCLASS_CLK, "clock-osc-24m",
> > &devp);
> > +	clkp1 = &to_clk_fixed_rate(devp)->clk;
> > +	clk_set_parent(clkp, clkp1);
> > +
> > +	/* Configure ARM PLL to 1.2GHz */
> > +	clk_get_by_id(IMX8MM_ARM_PLL, &clkp1);
> > +	clk_set_rate(clkp1, 1200000000UL);
> > +	clk_get_by_id(IMX8MM_ARM_PLL_OUT, &clkp1);
> > +	clk_enable(clkp1);
> > +	clk_set_parent(clkp, clkp1);
> > +
> > +	/* Configure DIV to 1.2GHz */
> > +	clk_get_by_id(IMX8MM_CLK_A53_DIV, &clkp1);
> > +	clk_set_rate(clkp1, 1200000000UL);
> > +#endif
> > +
> > +	return 0;
> > +}
> > +
> > +static const struct udevice_id imx8mm_clk_ids[] = {
> > +	{ .compatible = "fsl,imx8mm-ccm" },
> > +	{ },
> > +};
> > +
> > +U_BOOT_DRIVER(imx8mm_clk) = {
> > +	.name = "clk_imx8mm",
> > +	.id = UCLASS_CLK,
> > +	.of_match = imx8mm_clk_ids,
> > +	.ops = &imx8mm_clk_ops,
> > +	.probe = imx8mm_clk_probe,
> > +	.flags = DM_FLAG_PRE_RELOC,
> > +};
> 
> Reviewed-by: Lukasz Majewski <lukma at denx.de>
> Acked-by: Lukasz Majewski <lukma at denx.de>
> 
> As this and previous (3/4) patch is part of some other series - I do have a
> question: shall I take 3/4 and 4/4 to u-boot-clk or shall the whole series be
> taken by Stefano to u-boot-imx tree ?

There are also 1/4 and 2/4, would you please also take that two patches?

Thanks,
Peng.

> 
> 
> Best regards,
> 
> Lukasz Majewski
> 
> --
> 
> DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
> HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
> Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email:
> lukma at denx.de


More information about the U-Boot mailing list