[U-Boot] [PATCH v2 05/11] imx: tpc70: cosmetic: Replace magic numbers when setting ENET clock
Peng Fan
peng.fan at nxp.com
Fri Aug 9 07:07:58 UTC 2019
> Subject: [PATCH v2 05/11] imx: tpc70: cosmetic: Replace magic numbers
> when setting ENET clock
>
> This is a cosmetic change, just to use proper define instead of magic numbers.
>
> Signed-off-by: Lukasz Majewski <lukma at denx.de>
> ---
>
> board/k+p/kp_imx6q_tpc/kp_imx6q_tpc.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/board/k+p/kp_imx6q_tpc/kp_imx6q_tpc.c
> b/board/k+p/kp_imx6q_tpc/kp_imx6q_tpc.c
> index 7bdc64b1be..1dbd03efd8 100644
> --- a/board/k+p/kp_imx6q_tpc/kp_imx6q_tpc.c
> +++ b/board/k+p/kp_imx6q_tpc/kp_imx6q_tpc.c
> @@ -118,7 +118,8 @@ static int setup_fec_clock(void)
> struct iomuxc *iomuxc_regs = (struct iomuxc *)IOMUXC_BASE_ADDR;
>
> /* set gpr1[21] to select anatop clock */
> - clrsetbits_le32(&iomuxc_regs->gpr[1], 0x1 << 21, 0x1 << 21);
> + clrsetbits_le32(&iomuxc_regs->gpr[1],
> IOMUXC_GPR1_ENET_CLK_SEL_MASK,
> + IOMUXC_GPR1_ENET_CLK_SEL_MASK);
Would setbits_le32 work here?
Regards,
Peng.
>
> return enable_fec_anatop_clock(0, ENET_50MHZ); }
> --
> 2.11.0
More information about the U-Boot
mailing list