[U-Boot] [PATCH 1/2] usb: kbd: simplify coding for arrow keys

[Simon Glass]

Hi Heinrich,

On Fri, 9 Aug 2019 at 15:36, Heinrich Schuchardt <xypron.debian at gmx.de> wrote:
>
> On 6/24/19 8:49 PM, Simon Glass wrote:
> > Hi Heinrich,
> >
> > On Mon, 24 Jun 2019 at 11:36, Heinrich Schuchardt <xypron.glpk at gmx.de> wrote:
> >>
> >> On 6/24/19 3:56 PM, Simon Glass wrote:
> >>> On Sun, 16 Jun 2019 at 22:44, Heinrich Schuchardt <xypron.glpk at gmx.de> wrote:
> >>>>
> >>>> Avoid duplicate translation of arrow key codes.
> >>>>
> >>>> Signed-off-by: Heinrich Schuchardt <xypron.glpk at gmx.de>
> >>>> ---
> >>>>    common/usb_kbd.c | 31 +++++++++----------------------
> >>>>    1 file changed, 9 insertions(+), 22 deletions(-)
> >>>
> >>> Reviewed-by: Simon Glass <sjg at chromium.org>
> >>>
> >>> We should really have a test for this input stuff...
> >>>
> >>
> >> We already have.
> >>
> >> For low level analysis:
> >>
> >> => conitrace
> >> Waiting for your input
> >> To terminate type 'x'
> >> 61
> >> 1b 5b 32 30 7e
> >>
> >> For a higher level view:
> >>
> >> => setenv efi_selftest extended text input
> >> => bootefi selftest
> >> Executing 'extended text input'
> >> Waiting for your input
> >> To terminate type 'CTRL+x'
> >> Unicode char 100 ('d'), scan code 0 (Null)
> >> Unicode char 0 (Null), scan code 19 (+FN 9)
> >> Unicode char 0 (Null), scan code 19 (SHIFT+FN 9)
> >
> > I mean automated test :-)
> >
> > Regards,
> > Simon
>
> Hello Simon,
>
> drivers/usb/emul/sandbox_keyb.c seems to bypass the driver in
> common/usb_keyb.c instead of emulating a USB keyboard.
>
> Shouldn't it pass keyboard scan codes to common/usb_keyb.c?
>
> Would you know how to get this fixed? Then I can add the additional
> keyboard scan codes.

Well it looks like you have figured this out.

Regards,
Simon