[U-Boot] [PATCH v9 8/9] board: intel: Add new slimbootloader board

[Bin Meng]

Hi Aiden,

On Thu, Aug 8, 2019 at 10:42 PM Bin Meng <bmeng.cn at gmail.com> wrote:
>
> Hi Aiden,
>
> On Thu, Aug 8, 2019 at 10:35 PM Bin Meng <bmeng.cn at gmail.com> wrote:
> >
> > On Sat, Aug 3, 2019 at 4:31 PM Park, Aiden <aiden.park at intel.com> wrote:
> > >
> > > Add slimbootloader board to run U-boot as a Slim Bootloader payload
> > > - Add new board/intel/slimbootloader directory with minimum codes
> > > - Add slimbootloader configuration files
> > > - Add doc/board/intel/slimbootloader.rst
> > >
> > > Signed-off-by: Aiden Park <aiden.park at intel.com>
> > > Reviewed-by: Bin Meng <bmeng.cn at gmail.com>
> > > Reviewed-by: Andy Shevchenko <andy.shevchenko at gmail.com>
> > > ---
> > > Changes in v8:
> > >   * Add a space between acronym and (definition)
> > >
> > > Changes in v7:
> > >   * Adding slimbootloader.rst in index.rst
> > >
> > > Changes in v6:
> > >   * Select CONFIG_SYS_SLIMBOOTLOADER in board Kconfig
> > >   * Move USB_STORAGE and USB_KEYBOARD to board Kconfig
> > >   * Convert README to reST doc/board/intel/slimbootloader.rst
> > >
> > > Changes in v5:
> > >   * Remove X86_LOAD_FROM_32_BIT from slimbootloader_defconfig
> > >
> > > Changes in v3:
> > >   * Remove VENDOR_SLIMBOOTLOADER
> > >   * Use VENDOR_INTEL
> > >   * Move slimbootloader under board/intel/
> > >   * Enable generic CONFIGs in slimbootloader_defconfig
> > >   * Add more description in board/intel/slimbootloader/README
> > >
> > >  board/intel/Kconfig                         |  14 ++
> > >  board/intel/slimbootloader/Kconfig          |  28 ++++
> > >  board/intel/slimbootloader/Makefile         |   5 +
> > >  board/intel/slimbootloader/slimbootloader.c |  21 +++
> > >  board/intel/slimbootloader/start.S          |   9 +
> > >  configs/slimbootloader_defconfig            |  22 +++
> > >  doc/board/intel/index.rst                   |   1 +
> > >  doc/board/intel/slimbootloader.rst          | 174 ++++++++++++++++++++
> > >  include/configs/slimbootloader.h            |  62 +++++++
> > >  9 files changed, 336 insertions(+)
> > >  create mode 100644 board/intel/slimbootloader/Kconfig
> > >  create mode 100644 board/intel/slimbootloader/Makefile
> > >  create mode 100644 board/intel/slimbootloader/slimbootloader.c
> > >  create mode 100644 board/intel/slimbootloader/start.S
> > >  create mode 100644 configs/slimbootloader_defconfig
> > >  create mode 100644 doc/board/intel/slimbootloader.rst
> > >  create mode 100644 include/configs/slimbootloader.h
> > >
> >
> > Tested-by: Bin Meng <bmeng.cn at gmail.com>
>
> This time I successfully built the slimbootloader payload by following
> the instructions in the documentation and it succeeded to boot. Thanks
> for the efforts!
>
> However when testing zboot from U-Boot, I got:
>
> Error: Invalid Boot Flag (found 0x5aa5, expected 0xaa55)
> ## Kernel loading failed ...
> zboot - Boot bzImage
>
> The same kernel bzImage boots fine with "qemu-x86_defconfig" target.
> Did you see such issue?
>

Any comments on this error?

> This is not a show-stopper. I will apply this series soon.

Regards,
Bin