[U-Boot] [PATCH v3 1/2] disk: update to use SPL_PARTITIONS for SPL【请注意，邮件由sjg at google.com代发】

[Kever Yang]

On 2019/8/13 下午5:33, Simon Glass wrote:
> Hi Kever,
>
> On Thu, 8 Aug 2019 at 02:15, Kever Yang <kever.yang at rock-chips.com> wrote:
>> The SPL disk driver can not depends on SPL_FRAMEWORK&PARTITIONS,
> Spaces around &
>
>> which will enable the disk driver when we actually not need it.
>> Use a separate Kconfig to control the partition driver in SPL
>> will fix this issue caused by:
>> 91ff686562 blk: Rework guard around part_init call
> Can you please format to 75 columrns? These lines look a little short.


I can update the commit message with format update.

>
>> Signed-off-by: Kever Yang <kever.yang at rock-chips.com>
>> ---
>>
>> Changes in v3:
>> - update code in blk-uclass.c
>>
>> Changes in v2:
>> - add this patch
>>
>>   common/spl/Kconfig         |  2 +-
>>   disk/Kconfig               | 20 ++++++++++++--------
>>   disk/Makefile              |  2 +-
>>   drivers/block/blk-uclass.c |  2 +-
>>   scripts/Makefile.spl       |  2 +-
>>   5 files changed, 16 insertions(+), 12 deletions(-)
> So should this have a Fixes: tab?
>
> Reviewed-by: Simon Glass <sjg at chromium.org>
>
>> diff --git a/common/spl/Kconfig b/common/spl/Kconfig
>> index 5978fb2934..094680e54d 100644
>> --- a/common/spl/Kconfig
>> +++ b/common/spl/Kconfig
>> @@ -544,7 +544,7 @@ config SPL_LIBCOMMON_SUPPORT
>>
>>   config SPL_LIBDISK_SUPPORT
>>          bool "Support disk partitions"
>> -       select PARTITIONS
>> +       select SPL_PARTITIONS
>>          help
>>            Enable support for disk partitions within SPL. 'Disk' is something
>>            of a misnomer as it includes non-spinning media such as flash (as
>> diff --git a/disk/Kconfig b/disk/Kconfig
>> index 28fb81c2ee..43e76cb49d 100644
>> --- a/disk/Kconfig
>> +++ b/disk/Kconfig
>> @@ -4,9 +4,7 @@ menu "Partition Types"
>>   config PARTITIONS
>>          bool "Enable Partition Labels (disklabels) support"
>>          default y
>> -       select SPL_SPRINTF if SPL
> Why are you removing this? I don't see it mentioned in the commit message.


This is not removed, but MOVE to the new option SPL_PARTITIONS where it 
belongs to.


Thanks,

- Kever

>
>>          select TPL_SPRINTF if TPL
>> -       select SPL_STRTO if SPL
> Same here.
>
>>          select TPL_STRTO if TPL
>>          help
>>            Partition Labels (disklabels) Supported:
>> @@ -23,6 +21,12 @@ config PARTITIONS
>>            you must configure support for at least one non-MTD partition type
>>            as well.
> Regards,
> Simon
>