[U-Boot] [PATCH 2/7] net: mvpp2: Replace SMI implementation with marvell MDIO API

Nevo Hed nhed+uboot at starry.com
Wed Aug 14 17:09:16 UTC 2019

On Wed, Aug 14, 2019 at 11:39 AM Joe Hershberger
<joe.hershberger at gmail.com> wrote:
> On Fri, Aug 2, 2019 at 12:54 PM <nhed+uboot at starry.com> wrote:
> >
> > From: Ken Ma <make at marvell.com>
> >

> > -
> > -static int mvpp2_recv(struct udevice *dev, int flags, uchar **packetp)
> > +int mvpp2_recv(struct udevice *dev, int flags, uchar **packetp)
> Why does this need to be visible outside of this translation unit?

Hi Joe

Yes you are right, it should remain static.  This was in the
downstream commit from Ken I pulled in - I reversed that and made it
static again in my later commit in same patchset


let me know if it is preferred to rewrite this commit  (I just don't
know what the right way when submitting changes by others where the
others' org instructed them to abandoned them)

More information about the U-Boot mailing list