[U-Boot] [PATCH] cmd: avb: Fix requested partitions list

[Sam Protsenko]

Hi Eugeniu,

On Tue, Aug 13, 2019 at 7:59 PM Eugeniu Rosca <erosca at de.adit-jv.com> wrote:
>
> Hi Sam,
>
> On Fri, Aug 09, 2019 at 07:16:03PM +0300, Sam Protsenko wrote:
> > The requested_partitions[] array should contain only boot partitions.
> > Usually it's only 'boot' partition, as can be seen in [1]. Also, seems
> > like the requested_partitions[] are only used when there is no 'vbmeta'
> > partition [2], which is not a regular use-case.
> >
> > Make requested_partitions[] contain only 'boot' partition as it was
> > supposed to be, and also make that array to be a local in
> > do_avb_verify_part() function, as nobody else needs that.
> >
> > [1] https://android.googlesource.com/platform/external/avb/+/master/test/avb_slot_verify_unittest.cc#108
> > [2] https://android.googlesource.com/platform/external/avb/+/master/libavb/avb_slot_verify.c#1461
>
> The patches are much appreciated. Could we agree to avoid volatile
> references in the links, since those will point out to wrong lines after
> a couple of weeks? I think it's safer to either use the latest available
> commit id or tag, e.g.:
>
> [1] https://android.googlesource.com/platform/external/avb/+/5fbb42a189aa/test/avb_slot_verify_unittest.cc#108
> [2] https://android.googlesource.com/platform/external/avb/+/5fbb42a189aa/libavb/avb_slot_verify.c#1461
>

Sure, will send v2 soon. Can you please review this patch [1] please?
Without this AVB doesn't work (at least on X15 board, but I presume it
might affect more platforms, as code I'm fixing in that patch is
common). Also I send [2] for slots support in AVB. Will appreciate
your review.

Thanks!

[1] https://patchwork.ozlabs.org/patch/1147191/
[2] https://patchwork.ozlabs.org/patch/1144646/

> Thank you.
>
> --
> Best Regards,
> Eugeniu.