[U-Boot] [PATCH] Revert "net: macb: Fixed reading MII_LPA register"

[Anup Patel]

On Wed, Aug 14, 2019 at 4:01 PM Bin Meng <bmeng.cn at gmail.com> wrote:
>
> This reverts commit 1b0c9914cc75d1570359181ebd493cd5746cb0ed.
>
> Commit 1b0c9914cc75 ("net: macb: Fixed reading MII_LPA register")
> causes 100Mbps does not work any more with SiFive FU540 GEM on the
> HiFive Unleashed board. Revert it.
>
> Signed-off-by: Bin Meng <bmeng.cn at gmail.com>
> ---
>
>  drivers/net/macb.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/macb.c b/drivers/net/macb.c
> index c99cf66..25f7913 100644
> --- a/drivers/net/macb.c
> +++ b/drivers/net/macb.c
> @@ -643,7 +643,7 @@ static int macb_phy_init(struct macb_device *macb, const char *name)
>
>         /* First check for GMAC and that it is GiB capable */
>         if (gem_is_gigabit_capable(macb)) {
> -               lpa = macb_mdio_read(macb, MII_LPA);
> +               lpa = macb_mdio_read(macb, MII_STAT1000);

You can do this selectively by having boolean flag in macb_config which is
only set for SiFive Unleashed.

Regards,
Anup

>
>                 if (lpa & (LPA_1000FULL | LPA_1000HALF | LPA_1000XFULL |
>                                         LPA_1000XHALF)) {
> --
> 2.7.4
>
> _______________________________________________
> U-Boot mailing list
> U-Boot at lists.denx.de
> https://lists.denx.de/listinfo/u-boot