[U-Boot] [PATCH 1/1] easylogo: avoid buffer overrun

Tom Rini trini at konsulko.com
Mon Aug 19 14:39:36 UTC 2019


On Fri, Aug 16, 2019 at 12:11:57AM +0200, Heinrich Schuchardt wrote:
> On 8/15/19 11:54 PM, Heinrich Schuchardt wrote:
> >Building easylogo with `HOST_TOOLS_ALL=y make tools` results in a build
> >warning due to a possible buffer overrun:
> >
> >tools/easylogo/easylogo.c:453:4: note: ‘sprintf’ output between 7 and
> >262 bytes into a destination of size 256
> >     sprintf (str, "%s, 0x%02x", app, *dataptr++);
> >     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> >
> >Truncate the output to fit into the destination buffer.
> >
> >Signed-off-by: Heinrich Schuchardt <xypron.glpk at gmx.de>
> 
> Could we change .travis.yml and .gitlab-ci.yml to build all tools?

Don't see why not, once they'd be green again.  Follow up patch if
that's the only problem, v2 of the series if you find more things to
correct.  Thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190819/90a3e09e/attachment.sig>


More information about the U-Boot mailing list