[U-Boot] [PATCH v3 8/8] ata: ahci: Don't forget to clear upper address regs.

Tom Rini trini at konsulko.com
Tue Aug 20 16:19:32 UTC 2019


On Tue, Aug 06, 2019 at 05:08:52PM +0200, Frank Wunderlich wrote:

> From: Oleksandr Rybalko <ray at ddteam.net>
> 
> In 32bits mode upper bits need to be set to 0, otherwise controller will
> try to DMA into not existing memory and stops with error.
> 
> changes since v2: none
> 
> Tested-by: Frank Wunderlich <frank-w at public-files.de>
> Signed-off-by: Frank Wunderlich <frank-w at public-files.de>
> Signed-off-by: Oleksandr Rybalko <ray at ddteam.net>

This introduces a warning:
       x86:  w+   qemu-x86_64
+(qemu-x86_64)   writel_with_flush((u32)pp->cmd_slot, port_mmio + PORT_LST_ADDR);
+(qemu-x86_64)                     ^
+(qemu-x86_64) arch/x86/include/asm/io.h:71:53: note: in definition of macro 'writel'
+(qemu-x86_64)  #define writel(b, addr) (*(volatile u32 *)(addr) = (b))
+(qemu-x86_64)                                                      ^
+(qemu-x86_64) drivers/ata/ahci.c:596:2: note: in expansion of macro 'writel_with_flush'
+(qemu-x86_64)   ^~~~~~~~~~~~~~~~~
w+(qemu-x86_64) drivers/ata/ahci.c: In function 'ahci_port_start':
w+(qemu-x86_64) drivers/ata/ahci.c:596:20: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
  
-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190820/1a22b641/attachment.sig>


More information about the U-Boot mailing list