[U-Boot] [PATCH V3 1/4] clk: introduce enable_count

Peng Fan peng.fan at nxp.com
Mon Aug 26 01:08:21 UTC 2019


Hi Simon,

> Subject: Re: [PATCH V3 1/4] clk: introduce enable_count
> 
> Hi Peng,
> 
> On Wed, 21 Aug 2019 at 07:35, Peng Fan <peng.fan at nxp.com> wrote:
> >
> > As what Linux Kernel 5.3.0 provides when enable/disable clk, there is
> > an enable_count in clk_core_disable/enable. Introduce enable_count to
> > track the clk enable/disable count when clk_enable/disable for CCF.
> > And Initialize enable_count to 0 when register the clk.
> >
> > And clk tree dump with enable_count will be supported, it will be easy
> > for us to check the clk status with enable_count
> >
> > Signed-off-by: Peng Fan <peng.fan at nxp.com>
> > ---
> >
> > V3:
> >  None
> >  CI:
> > https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Ftrav
> >
> is-ci.org%2FMrVan%2Fu-boot%2Fbuilds%2F574753709&data=02%7C01
> %7Cpen
> >
> g.fan%40nxp.com%7C626abf64d2f8431f2bcc08d72813bbb2%7C686ea1d3bc
> 2b4c6fa
> >
> 92cd99c5c301635%7C0%7C0%7C637021937522749993&sdata=PQs59S
> 1gAK8P%2B
> > HGOfXKweJlVHqKGJDZ11jM%2F45%2BCz7E%3D&reserved=0
> > V2:
> >  Improve commit log
> >  Rename enable_cnt to enable_count following Linux Kernel
> >
> >  drivers/clk/clk.c            | 1 +
> >  drivers/clk/clk_fixed_rate.c | 1 +
> >  include/clk.h                | 1 +
> >  3 files changed, 3 insertions(+)
> 
> Reviewed-by: Simon Glass <sjg at chromium.org>
> 
> Do you think it would be worth making this a u8 to save space?

The structured is not marked __packed, so u8 would not save space.

> 
> Or perhaps this feature could be optional?

I'll try.

Thanks,
Peng.

> 
> Regards,
> Simon


More information about the U-Boot mailing list