[U-Boot] [PATCH 03/47] configs: T2080RDB: Enable PCIe driver

[Z.q. Hou]

Hi Bin,

Thanks a lot for your comments!

> -----Original Message-----
> From: Bin Meng <bmeng.cn at gmail.com>
> Sent: 2019年8月26日 22:48
> To: Z.q. Hou <zhiqiang.hou at nxp.com>
> Cc: U-Boot Mailing List <u-boot at lists.denx.de>; Prabhakar Kushwaha
> <prabhakar.kushwaha at nxp.com>; Wolfgang Denk <wd at denx.de>; Priyanka
> Jain <priyanka.jain at nxp.com>; Shengzhou Liu <shengzhou.liu at nxp.com>
> Subject: Re: [U-Boot] [PATCH 03/47] configs: T2080RDB: Enable PCIe driver
> 
> Hi Zhiqiang,
> 
> On Tue, Jul 23, 2019 at 9:24 PM Hou Zhiqiang <Zhiqiang.Hou at nxp.com>
> wrote:
> >
> > Enable the DM PCIe driver in T2080RDB defconfig.
> >
> > Signed-off-by: Hou Zhiqiang <Zhiqiang.Hou at nxp.com>
> > ---
> >  configs/T2080RDB_NAND_defconfig     | 4 ++++
> >  configs/T2080RDB_SDCARD_defconfig   | 4 ++++
> >  configs/T2080RDB_SPIFLASH_defconfig | 4 ++++
> >  configs/T2080RDB_defconfig          | 4 ++++
> >  4 files changed, 16 insertions(+)
> >
> > diff --git a/configs/T2080RDB_NAND_defconfig
> > b/configs/T2080RDB_NAND_defconfig index 7eb7058..30ec72b 100644
> > --- a/configs/T2080RDB_NAND_defconfig
> > +++ b/configs/T2080RDB_NAND_defconfig
> > @@ -57,6 +57,10 @@ CONFIG_PHYLIB=y
> >  CONFIG_PHY_AQUANTIA=y
> >  CONFIG_E1000=y
> >  CONFIG_MII=y
> > +CONFIG_DM=y
> > +CONFIG_DM_PCI=y
> > +CONFIG_DM_PCI_COMPAT=y
> 
> Why do we need this option? I vaguely remember I commented in as similar
> patch for some other board (maybe layerscape arm?)

We discussed this during adding PCIe DM driver on T2080QDS, so it's the same
reason.

Thanks,
Zhiqiang

> 
> > +CONFIG_PCIE_FSL=y
> >  CONFIG_SYS_NS16550=y
> >  CONFIG_SPI=y
> >  CONFIG_FSL_ESPI=y
> > diff --git a/configs/T2080RDB_SDCARD_defconfig
> > b/configs/T2080RDB_SDCARD_defconfig
> > index 9ea6698..22c2e05 100644
> > --- a/configs/T2080RDB_SDCARD_defconfig
> > +++ b/configs/T2080RDB_SDCARD_defconfig
> > @@ -56,6 +56,10 @@ CONFIG_PHYLIB=y
> >  CONFIG_PHY_AQUANTIA=y
> >  CONFIG_E1000=y
> >  CONFIG_MII=y
> > +CONFIG_DM=y
> > +CONFIG_DM_PCI=y
> > +CONFIG_DM_PCI_COMPAT=y
> > +CONFIG_PCIE_FSL=y
> >  CONFIG_SYS_NS16550=y
> >  CONFIG_SPI=y
> >  CONFIG_FSL_ESPI=y
> > diff --git a/configs/T2080RDB_SPIFLASH_defconfig
> > b/configs/T2080RDB_SPIFLASH_defconfig
> > index 988897b..e70fa0d 100644
> > --- a/configs/T2080RDB_SPIFLASH_defconfig
> > +++ b/configs/T2080RDB_SPIFLASH_defconfig
> > @@ -56,6 +56,10 @@ CONFIG_SPI_FLASH_STMICRO=y
> CONFIG_PHYLIB=y
> > CONFIG_PHY_AQUANTIA=y  CONFIG_E1000=y
> > +CONFIG_DM=y
> > +CONFIG_DM_PCI=y
> > +CONFIG_DM_PCI_COMPAT=y
> > +CONFIG_PCIE_FSL=y
> >  CONFIG_MII=y
> >  CONFIG_SYS_NS16550=y
> >  CONFIG_SPI=y
> > diff --git a/configs/T2080RDB_defconfig b/configs/T2080RDB_defconfig
> > index 3f7e282..b620349 100644
> > --- a/configs/T2080RDB_defconfig
> > +++ b/configs/T2080RDB_defconfig
> > @@ -45,6 +45,10 @@ CONFIG_PHYLIB=y
> >  CONFIG_PHY_AQUANTIA=y
> >  CONFIG_E1000=y
> >  CONFIG_MII=y
> > +CONFIG_DM=y
> > +CONFIG_DM_PCI=y
> > +CONFIG_DM_PCI_COMPAT=y
> > +CONFIG_PCIE_FSL=y
> >  CONFIG_SYS_NS16550=y
> >  CONFIG_SPI=y
> >  CONFIG_FSL_ESPI=y
> > --
> 
> Regards,
> Bin