[U-Boot] [PATCH 03/47] configs: T2080RDB: Enable PCIe driver

[Bin Meng]

Hi Zhiqiang,

On Tue, Aug 27, 2019 at 11:09 AM Z.q. Hou <zhiqiang.hou at nxp.com> wrote:
>
> Hi Bin,
>
> > -----Original Message-----
> > From: Bin Meng <bmeng.cn at gmail.com>
> > Sent: 2019年8月27日 10:51
> > To: Z.q. Hou <zhiqiang.hou at nxp.com>
> > Cc: U-Boot Mailing List <u-boot at lists.denx.de>; Prabhakar Kushwaha
> > <prabhakar.kushwaha at nxp.com>; Wolfgang Denk <wd at denx.de>; Priyanka
> > Jain <priyanka.jain at nxp.com>; Shengzhou Liu <shengzhou.liu at nxp.com>
> > Subject: Re: [U-Boot] [PATCH 03/47] configs: T2080RDB: Enable PCIe driver
> >
> > Hi Zhiqiang,
> >
> > On Tue, Aug 27, 2019 at 10:05 AM Z.q. Hou <zhiqiang.hou at nxp.com> wrote:
> > >
> > > Hi Bin,
> > >
> > > Thanks a lot for your comments!
> > >
> > > > -----Original Message-----
> > > > From: Bin Meng <bmeng.cn at gmail.com>
> > > > Sent: 2019年8月26日 22:48
> > > > To: Z.q. Hou <zhiqiang.hou at nxp.com>
> > > > Cc: U-Boot Mailing List <u-boot at lists.denx.de>; Prabhakar Kushwaha
> > > > <prabhakar.kushwaha at nxp.com>; Wolfgang Denk <wd at denx.de>;
> > Priyanka
> > > > Jain <priyanka.jain at nxp.com>; Shengzhou Liu
> > <shengzhou.liu at nxp.com>
> > > > Subject: Re: [U-Boot] [PATCH 03/47] configs: T2080RDB: Enable PCIe
> > > > driver
> > > >
> > > > Hi Zhiqiang,
> > > >
> > > > On Tue, Jul 23, 2019 at 9:24 PM Hou Zhiqiang <Zhiqiang.Hou at nxp.com>
> > > > wrote:
> > > > >
> > > > > Enable the DM PCIe driver in T2080RDB defconfig.
> > > > >
> > > > > Signed-off-by: Hou Zhiqiang <Zhiqiang.Hou at nxp.com>
> > > > > ---
> > > > >  configs/T2080RDB_NAND_defconfig     | 4 ++++
> > > > >  configs/T2080RDB_SDCARD_defconfig   | 4 ++++
> > > > >  configs/T2080RDB_SPIFLASH_defconfig | 4 ++++
> > > > >  configs/T2080RDB_defconfig          | 4 ++++
> > > > >  4 files changed, 16 insertions(+)
> > > > >
> > > > > diff --git a/configs/T2080RDB_NAND_defconfig
> > > > > b/configs/T2080RDB_NAND_defconfig index 7eb7058..30ec72b
> > 100644
> > > > > --- a/configs/T2080RDB_NAND_defconfig
> > > > > +++ b/configs/T2080RDB_NAND_defconfig
> > > > > @@ -57,6 +57,10 @@ CONFIG_PHYLIB=y
> > CONFIG_PHY_AQUANTIA=y
> > > > > CONFIG_E1000=y  CONFIG_MII=y
> > > > > +CONFIG_DM=y
> > > > > +CONFIG_DM_PCI=y
> > > > > +CONFIG_DM_PCI_COMPAT=y
> > > >
> > > > Why do we need this option? I vaguely remember I commented in as
> > > > similar patch for some other board (maybe layerscape arm?)
> > >
> > > We discussed this during adding PCIe DM driver on T2080QDS, so it's
> > > the same reason.
> >
> > I dug into the mailing list archive, and I see:
> > https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.d
> > enx.de%2Fpipermail%2Fu-boot%2F2019-May%2F370756.html&data=0
> > 2%7C01%7Czhiqiang.hou%40nxp.com%7C7e2ca21c87dd4d497e4008d72a99
> > 626b%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C63702471058
> > 1230533&sdata=Ams8RKheHQcU9pgTAuTugXcLCrzbRFk5xOm6ubu84R
> > Y%3D&reserved=0
> >
> > In that thread, you wrote:
> >
> > "I will submit a patch to remove the DM_PCI_COMPAT when all driver has
> > been converted."
> >
> > So I believe you guys have not converted all PowerPC drivers to DM, hence
> > it's still left there?
>
> Yes, I will remove it when DM_ETH is added, otherwise there will be build errors.
>

Great!, so,
Reviewed-by: Bin Meng <bmeng.cn at gmail.com>

Regards,
Bin