[U-Boot] [PATCH] mmc: dw_mmc: fix timeout calculate method

Kever Yang kever.yang at rock-chips.com
Thu Aug 29 07:17:02 UTC 2019


Add ARC maintainers.


On 2019/8/27 下午5:58, Peng Fan wrote:
> Hi Kever,
>
>> -----Original Message-----
>> From: U-Boot <u-boot-bounces at lists.denx.de> On Behalf Of Peng Fan
>> Sent: 2019年8月27日 15:40
>> To: Kever Yang <kever.yang at rock-chips.com>; u-boot at lists.denx.de
>> Cc: trini at konsulko.com
>> Subject: Re: [U-Boot] [PATCH] mmc: dw_mmc: fix timeout calculate method
>>
>>> Subject: [PATCH] mmc: dw_mmc: fix timeout calculate method
>>>
>>> There are two cases not been considered:
>>> - use uint for timeout, it will overflow when size bigger than 512KB for
>>>    it *8*1000 at the beginning, but we may use size up to 32MB;
>>> - The timeout is using clock speed for data rate, but the device may not
>>>    have such high speed, eg. clock is 52MHz while the device write speed
>> may
>>>    be less than 10MB/s.
>>>
>>> Fix them in this patch, the max timeout is about 6500 when size is
>>> 32MB after fix.
>>>
>>> Signed-off-by: Kever Yang <kever.yang at rock-chips.com>
> This patch breaks build, I need drop it.
> See build:
> https://travis-ci.org/MrVan/u-boot/jobs/577210464
The error happens only in ARC architecture, and seems like the arc 
compiler not support

64bit div?

Any idea on how to fix this?


Thanks,
- Kever
>
> Regards,
> Peng.
>
>> Applied to mmc/master.
>>
>> Thanks,
>> Peng.
>> _______________________________________________
>> U-Boot mailing list
>> U-Boot at lists.denx.de
>> https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.d
>> enx.de%2Flistinfo%2Fu-boot&data=02%7C01%7CPeng.Fan%40nxp.com
>> %7Cec929026da5f42951b6108d72ac1c446%7C686ea1d3bc2b4c6fa92cd99c
>> 5c301635%7C0%7C0%7C637024884027193189&sdata=SPBna8IBqgpo9
>> %2F6ab1YO5sbpX6NGgkCowt0oLclRHEk%3D&reserved=0




More information about the U-Boot mailing list