[U-Boot] [RFC PATCH] patman: Use the Change-Id, version, and prefix in the Message-Id

Johannes Berg johannes at sipsolutions.net
Wed Aug 28 21:05:14 UTC 2019

Hi Doug,

Some comments on the actual mechanics here (vs. on the kernel list I
picked this up from).

It seems like perhaps you could increase the "count" variable. You got:

20190828132723.0.RFC.Ie6289f437ae533d7fcaddfcee9202f0e92c6b2b9 at changeid

but usually patches are numbered starting from 1, not 0. Especially for
series, it might be easier to understand if that was the same here.

I'd probably also put it after the tag, so you'd have "RFC.1" instead of
"0.RFC", I'm saying it mostly because I originally thought you somehow
generated a timestamp with a decimal point :-)

Obviously none of that really matters, but it'd be easier to understand
(and if necessary reverse-engineer) IMHO.


More information about the U-Boot mailing list