[U-Boot] [PATCH 1/4] x86: Drop weak version board_get_usable_ram_top()

Park, Aiden aiden.park at intel.com
Thu Aug 29 20:46:02 UTC 2019


> -----Original Message-----
> From: Heinrich Schuchardt [mailto:xypron.glpk at gmx.de]
> Sent: Thursday, August 29, 2019 12:27 PM
> To: Bin Meng <bmeng.cn at gmail.com>; Simon Glass <sjg at chromium.org>; Park,
> Aiden <aiden.park at intel.com>; U-Boot Mailing List <u-boot at lists.denx.de>
> Subject: Re: [PATCH 1/4] x86: Drop weak version board_get_usable_ram_top()
> 
> On 8/29/19 11:53 AM, Bin Meng wrote:
> > Every x86 platform provides board_get_usable_ram_top(), hence there is
> > no need to provide a weak version board_get_usable_ram_top(), not to
> > mention there is another weak version board_get_usable_ram_top() in
> > common/board_f.c.
> >
> > Signed-off-by: Bin Meng <bmeng.cn at gmail.com>
> 
> Reviewed-by: Heinrich Schuchardt <xypron.glpk at gmx.de>
>

Reviewed-by: Aiden Park <aiden.park at intel.com>
 
> > ---
> >
> >   arch/x86/lib/init_helpers.c | 6 ------
> >   1 file changed, 6 deletions(-)
> >
> > diff --git a/arch/x86/lib/init_helpers.c b/arch/x86/lib/init_helpers.c
> > index 5e19f13..4774a9b 100644
> > --- a/arch/x86/lib/init_helpers.c
> > +++ b/arch/x86/lib/init_helpers.c
> > @@ -10,12 +10,6 @@
> >
> >   DECLARE_GLOBAL_DATA_PTR;
> >
> > -/* Get the top of usable RAM */
> > -__weak ulong board_get_usable_ram_top(ulong total_size) -{
> > -	return gd->ram_size;
> > -}
> > -
> >   int init_cache_f_r(void)
> >   {
> >   #if CONFIG_IS_ENABLED(X86_32BIT_INIT) && !defined(CONFIG_HAVE_FSP)
> > && \
> >



More information about the U-Boot mailing list