[U-Boot] [PATCH] mx53loco: Fix U-Boot corruption after saving the environment

Tom Rini trini at konsulko.com
Fri Aug 30 18:14:41 UTC 2019


On Fri, Aug 30, 2019 at 01:58:29PM -0300, Fabio Estevam wrote:

> U-Boot binary has grown in such a way that it goes beyond the reserved
> area for the environment variables.
>     
> Running "saveenv" causes U-Boot to hang because of this overlap.
>     
> Fix this problem by increasing the CONFIG_ENV_OFFSET size.
>     
> Also, in order to prevent this same problem in the future, use
> CONFIG_BOARD_SIZE_LIMIT, which will detect the overlap in build-time.
>     
> CONFIG_BOARD_SIZE_LIMIT does not accept math expressions, so declare
> CONFIG_ENV_OFFSET with its direct value instead.
> 
> Signed-off-by: Fabio Estevam <festevam at gmail.com>

Gah!

Are there more i.mx platforms that are not setting BOARD_SIZE_LIMIT
today?  I assume there are, sadly.  Can you audit and catch the rest of
these likely problems, and add limits so we won't repeat this again.
Thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190830/529e1dc2/attachment.sig>


More information about the U-Boot mailing list