[U-Boot] [EXT] Re: [PATCH v2 1/5] spl: dm: disable SPI DM flash for non-DM SPL

[Chuanhua Han]

> -----Original Message-----
> From: Tom Rini <trini at konsulko.com>
> Sent: 2019年5月31日 3:43
> To: Chuanhua Han <chuanhua.han at nxp.com>
> Cc: jagan at openedev.com; wd at denx.de; Shengzhou Liu
> <shengzhou.liu at nxp.com>; Ruchika Gupta <ruchika.gupta at nxp.com>; Pan
> Jiafei <Jiafei.Pan at freescale.com>; u-boot at lists.denx.de; Jiafei Pan
> <jiafei.pan at nxp.com>; Yinbo Zhu <yinbo.zhu at nxp.com>
> Subject: Re: [EXT] Re: [U-Boot] [PATCH v2 1/5] spl: dm: disable SPI DM flash for
> non-DM SPL
> 
> On Thu, May 30, 2019 at 10:45:10AM +0000, Chuanhua Han wrote:
> >
> >
> > > -----Original Message-----
> > > From: Tom Rini <trini at konsulko.com>
> > > Sent: 2019年5月24日 22:24
> > > To: Chuanhua Han <chuanhua.han at nxp.com>
> > > Cc: jagan at openedev.com; wd at denx.de; Shengzhou Liu
> > > <shengzhou.liu at nxp.com>; Ruchika Gupta <ruchika.gupta at nxp.com>; Pan
> > > Jiafei <Jiafei.Pan at freescale.com>; u-boot at lists.denx.de; Jiafei Pan
> > > <jiafei.pan at nxp.com>; Yinbo Zhu <yinbo.zhu at nxp.com>
> > > Subject: [EXT] Re: [U-Boot] [PATCH v2 1/5] spl: dm: disable SPI DM
> > > flash for non-DM SPL
> > >
> > > On Fri, May 24, 2019 at 12:40:53PM +0800, Chuanhua Han wrote:
> > >
> > > > This patch solves the problem that spiboot cannot be performed in
> > > > non-DM SPL.
> > > >
> > > > Signed-off-by: Pan Jiafei <Jiafei.Pan at freescale.com>
> > > > Signed-off-by: Chuanhua Han <chuanhua.han at nxp.com>
> > > > ---
> > > > Changes in v2:
> > > > 	- No change.
> > > >
> > > >  include/config_uncmd_spl.h | 1 +
> > > >  1 file changed, 1 insertion(+)
> > > >
> > > > diff --git a/include/config_uncmd_spl.h
> > > > b/include/config_uncmd_spl.h index c2f9735ce7..da94b3d9df 100644
> > > > --- a/include/config_uncmd_spl.h
> > > > +++ b/include/config_uncmd_spl.h
> > > > @@ -15,6 +15,7 @@
> > > >  #undef CONFIG_DM_GPIO
> > > >  #undef CONFIG_DM_I2C
> > > >  #undef CONFIG_DM_SPI
> > > > +#undef CONFIG_DM_SPI_FLASH
> > > >  #endif
> > > >
> > > >  #undef CONFIG_DM_WARN
> > >
> > > Long term, this shows places where we need CONFIG_SPL_DM_xxx and
> > > code should be using CONFIG_IS_ENABLED(DM_xxx).  Please update at
> > > least the DM_SPI_FLASH case you're finding to behave like that, thanks!
> > I don't understand you very much. Are you saying to modify the spi-flash
> related code?
> 
> Correct.  include/config_uncmd_spl.h should be removed as there should,
> long term, be no cases of code in SPL that we can / should exclude not
> guarded by CONFIG_SPL_xxx instead.
Do you mean include/config_uncmd_spl.h will be deleted in the future? Why did you start adding this file?
> 
> --
> Tom