[U-Boot] [RFC 5/6] ARM: dts: colibri_imx7: Add lcdif node

[Igor Opaniuk]

Hi Fabio,

On Wed, Jun 5, 2019 at 1:06 AM Fabio Estevam <festevam at gmail.com> wrote:
>
> Hi Igor,
>
> On Mon, Jun 3, 2019 at 6:06 PM Igor Opaniuk <igor.opaniuk at gmail.com> wrote:
>
> > +&lcdif {
> > +       u-boot,dm-pre-reloc;
> > +       status = "okay";
> > +
> > +       display-timings {
> > +               native-mode = <&timing_vga>;
> > +
> > +               /* Standard VGA timing */
> > +               timing_vga: 640x480 {
> > +                       u-boot,dm-pre-reloc;
> > +                       clock-frequency = <25175000>;
> > +                       hactive = <640>;
> > +                       vactive = <480>;
> > +                       hback-porch = <48>;
> > +                       hfront-porch = <16>;
> > +                       vback-porch = <33>;
> > +                       vfront-porch = <10>;
> > +                       hsync-len = <96>;
> > +                       vsync-len = <2>;
> > +
> > +                       de-active = <1>;
> > +                       hsync-active = <0>;
> > +                       vsync-active = <0>;
> > +                       pixelclk-active = <0>
>
> This is the deprecated style mxsfb fbdev binding.
>
> In the kernel we no longer use this style as documented in
> Documentation/devicetree/bindings/display/mxsfb.txt
>
> If we follow this route in U-Boot then we will diverge from the kernel
> recommended bindings.

Initially I copy-pasted the whole DT node "as it is" from the linux
kernel dts, but found out that existing
DT wrapper for parsing display timings
(ofnode_decode_display_timing())) isn't able to parse it properly,
so I just changed it to conform the same structure as similar nodes in
other DTS files.

Thanks for letting me know, probably ofnode_decode_display_timing()
implementation should
be adjusted as well.

Regards,
Igor



-- 
Best regards - Freundliche Grüsse - Meilleures salutations

Igor Opaniuk

mailto: igor.opaniuk at gmail.com
skype: igor.opanyuk
+380 (93) 836 40 67
http://ua.linkedin.com/in/iopaniuk