[U-Boot] x86: SPI flash broken with SPI NOR

[Bin Meng]

Hi Vignesh,

On Sat, Apr 27, 2019 at 12:26 AM Vignesh Raghavendra <vigneshr at ti.com> wrote:
>
> Bin,
>
> On 26/04/19 7:33 PM, Bin Meng wrote:
> > Hi Simon,
> >
> > On Fri, Apr 26, 2019 at 7:26 AM Simon Glass <sjg at chromium.org> wrote:
> >>
> >> Hi Bin,
> >>
> >> I find that 'sf test 0 1000' does not work anymore since this commit:
> >>
> >> c4e8862308 mtd: spi: Switch to new SPI NOR framework
> >>
> >> Have you seen any problems? This seems to prevent proper SPI flash writing (not sure about reading).
> >
> > Yes, this seems to be broken. I just tested it on MinnowMax.
> >
>
> What is the flash part on this board?
>
>
> > 'sf probe' does not succeed anymore.
> >
>
> Could you enable all debug prints in spi_mem_exec_op() in spi-mem.c:
> https://elixir.bootlin.com/u-boot/latest/source/drivers/spi/spi-mem.c#L376
>
> And the post the full log here. If the log is too big please paste it to pastebin.ubuntu.com
>
> Also please apply http://patchwork.ozlabs.org/patch/1090121/ on top of latest tree before doing any write to flash
>
> Sorry for the trouble.
>

Sorry for the long delay. I finally got time to look into this.

However with the latest u-boot/master, the SPI flash seems to work
again on Intel MinnowMax. Did you recall anything changes in the
spi-nor recently?

Regards,
Bin