[U-Boot] [PATCH 3/4 v2] test: dm: Add a test for PCI Enhanced Allocation
bmeng.cn at gmail.com
Thu Jun 6 10:27:28 UTC 2019
On Thu, Jun 6, 2019 at 3:38 PM Alexandru Marginean
<alexandru.marginean at nxp.com> wrote:
> Hi Bin,
> On 6/5/2019 1:05 PM, Bin Meng wrote:
> > Hi Alex,
> > On Tue, Jun 4, 2019 at 8:46 PM Alex Marginean <alexm.osslist at gmail.com> wrote:
> >> This test is built on top of the existing swap_case driver. It adds EA
> >> capability structure support to swap_case and uses that to map BARs.
> >> BAR1 works as it used to, swapping upper/lower case. BARs 2,4 map to a
> >> couple of magic values.
> >> Signed-off-by: Alex Marginean <alexm.osslist at gmail.com>
> >> ---
> >> Changes in v2:
> >> - new patch, v1 didn't have a test
> >> arch/sandbox/dts/test.dts | 8 +++
> >> arch/sandbox/include/asm/test.h | 13 ++++
> >> drivers/misc/swap_case.c | 102 +++++++++++++++++++++++++++++++-
> >> test/dm/pci.c | 50 ++++++++++++++++
> >> 4 files changed, 172 insertions(+), 1 deletion(-)
> > Well done!
> > Reviewed-by: Bin Meng <bmeng.cn at gmail.com>
> > Tested-by: Bin Meng <bmeng.cn at gmail.com>
> > But please see some nits below:
> I'm replying from the nxp account, apparently google decided this is
> just spam and it's not worth sending out through gmail.
> I'll send a v3 with fixes for you comments, should I keep either of your
> two tags on this patch?
Yes, please keep the two tags in the v3. thanks!
More information about the U-Boot