[U-Boot] Pull request: u-boot-spi/master

Heiko Schocher hs at denx.de
Fri Jun 7 08:56:11 UTC 2019


Hello Mario,

Am 07.06.2019 um 09:51 schrieb Mario Six:
> (adding Heiko, since he's the maintainer of the board in question)
> 
> On Fri, May 24, 2019 at 9:34 PM Jagan Teki <jagan at amarulasolutions.com> wrote:

Huch, missed this Email ...

>>
>> Hi Mario,
>>
>> On Tue, May 21, 2019 at 4:42 PM Tom Rini <trini at konsulko.com> wrote:
>>>
>>> On Mon, May 20, 2019 at 10:48:23PM +0530, Jagan Teki wrote:
>>>
>>>> Hi Tom,
>>>>
>>>> Please pull this PR.
>>>>
>>>> Summary:
>>>> - mpc8xxx spi driver fixes (Mario)
>>>> - mpc8xxx spi dm conversion (Mario, Jagan)
>>>> - SPI DM Migration update (Jagan)
>>>>
>>>> The following changes since commit 748198cb8d32d41bc35e6f492bac9948f339bece:
>>>>
>>>>    Revert "Makefile: Prioritize external dtb if defined" (2019-05-19 18:09:35 -0400)
>>>>
>>>> are available in the Git repository at:
>>>>
>>>>    git://git.denx.de/u-boot-spi.git master
>>>>
>>>> for you to fetch changes up to 93842e580cee40c9d3e70de625e4bd826a749e65:
>>>>
>>>>    dm: MIGRATION: Update migration status for SPI (2019-05-20 22:18:54 +0530)
>>>>
>>>
>>> NAK:
>>>     powerpc:  +   ids8313
>>> +(ids8313) cmd/built-in.o: In function `do_spi_xfer':
>>> +(ids8313) build/../cmd/spi.c:53: undefined reference to `spi_setup_slave'
>>> +(ids8313) build/../cmd/spi.c:60: undefined reference to `spi_claim_bus'
>>> +(ids8313) build/../cmd/spi.c:63: undefined reference to `spi_xfer'
>>> +(ids8313) build/../cmd/spi.c:80: undefined reference to `spi_release_bus'
>>> +(ids8313) build/../cmd/spi.c:82: undefined reference to `spi_free_slave'
>>> +(ids8313) common/built-in.o: In function `jumptable_init':
>>> +(ids8313) build/../include/_exports.h:56: undefined reference to `spi_setup_slave'
>>> +(ids8313) build/../include/_exports.h:58: undefined reference to `spi_free_slave'
>>> +(ids8313) build/../include/_exports.h:65: undefined reference to `spi_claim_bus'
>>> +(ids8313) build/../include/_exports.h:66: undefined reference to `spi_release_bus'
>>> +(ids8313) build/../include/_exports.h:67: undefined reference to `spi_xfer'
>>> +(ids8313) make[1]: *** [Makefile:1552: u-boot] Error 1
>>> +(ids8313) make: *** [Makefile:148: sub-make] Error 2
>>>
>>
>> Any help?
> 
> @Heiko: I'll post a minimal patch that starts DM conversion on ids8313; I used
> the mpc8313erdb tree from the Linux sources for now. No guarantees for
> functionality, but it does compile.

Just saw this patch .. it is really a fast shot :-P

I just wrote an EMail to the customer, if we should remove the board
from mainline (or convert it).

> @Jagan: Could you rebase this series on the current master to pull in my
> MPC83xx DM updates, and then apply the previously mentioned ids8313 patch after
> Heiko gave his OK?

As it blocks spi patches ... Isn,t it better we remove SPI functionality
from the ids8313 board instead of adding a DTS which does not really fit?

bye,
Heiko
-- 
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-52   Fax: +49-8142-66989-80   Email: hs at denx.de


More information about the U-Boot mailing list