[U-Boot] [PATCH 5/5] sunxi: use boot source for determining environment location

Andre Przywara andre.przywara at arm.com
Sat Jun 8 01:26:58 UTC 2019


Currently we only support to load the environment from raw MMC or FAT
locations on Allwinner boards. With the advent of SPI flash we probably
also want to support using the environment there, so we need to become
a bit more flexible.

Change the environment priority function to take the boot source into
account. When booted from eMMC or SD card, we use FAT or MMC, if
configured, as before.
If we are booted from SPI flash, we try to use the environment from
there, if possible. The same is true for NAND flash booting, although
this is somewhat theoretical right now (as untested).

This way we can use the same image for SD and SPI flash booting, which
allows us to simply copy a booted image from SD card to the SPI flash,
for instance.

Signed-off-by: Andre Przywara <andre.przywara at arm.com>
---
 board/sunxi/board.c | 39 +++++++++++++++++++++++++++++++--------
 1 file changed, 31 insertions(+), 8 deletions(-)

diff --git a/board/sunxi/board.c b/board/sunxi/board.c
index 5802b079b6..b95a1a0feb 100644
--- a/board/sunxi/board.c
+++ b/board/sunxi/board.c
@@ -192,21 +192,44 @@ void i2c_init_board(void)
 #endif
 }
 
-#if defined(CONFIG_ENV_IS_IN_MMC) && defined(CONFIG_ENV_IS_IN_FAT)
 enum env_location env_get_location(enum env_operation op, int prio)
 {
-	switch (prio) {
-	case 0:
-		return ENVL_FAT;
+	enum env_location boot_loc = ENVL_UNKNOWN;
 
-	case 1:
-		return ENVL_MMC;
+	gd->env_load_prio = prio;
 
+	switch (sunxi_get_boot_device()) {
+	case BOOT_DEVICE_MMC1:
+	case BOOT_DEVICE_MMC2:
+		boot_loc = ENVL_FAT;
+		break;
+	case BOOT_DEVICE_NAND:
+#ifdef CONFIG_ENV_IS_IN_NAND
+		boot_loc = ENVL_NAND;
+#endif
+		break;
+	case BOOT_DEVICE_SPI:
+#ifdef CONFIG_ENV_IS_IN_SPI_FLASH
+		boot_loc = ENVL_SPI_FLASH;
+#endif
+		break;
+	case BOOT_DEVICE_BOARD:
+		boot_loc = ENVL_FAT;	/* dummy to prevent crash */
+		break;
 	default:
-		return ENVL_UNKNOWN;
+		break;
 	}
-}
+
+	/* Always try to access the environment on the boot device first. */
+	if (prio == 0)
+		return boot_loc;
+
+#ifdef CONFIG_ENV_IS_IN_MMC
+	if (prio == 1 && boot_loc == ENVL_FAT)
+		return ENVL_MMC;
 #endif
+	return ENVL_UNKNOWN;
+}
 
 /* Determine whether to use the environment from SD card or eMMC. */
 int mmc_get_env_dev(void)
-- 
2.14.5



More information about the U-Boot mailing list