[U-Boot] [PATCH v7 11/15] mmc: sdhci: Add support for HOST_CONTROL2 and setting UHS timings

[Faiz Abbas]

Hi Andreas,

On 10/06/19 8:44 PM, Andreas Dannenberg wrote:
> Hi Faiz,
> 
> On Fri, Jun 07, 2019 at 09:07:32AM +0530, Lokesh Vutla wrote:
>>
>>
>> On 06/06/19 7:24 PM, Faiz Abbas wrote:
>>> The HOST_CONTROL2 register is a part of SDHC v3.00 and not just specific
>>> to arasan/zynq controllers. Add the same to sdhci.h.
>>>
>>> Also create a common API to set UHS timings in HOST_CONTROL2.
>>>
>>> Signed-off-by: Faiz Abbas <faiz_abbas at ti.com>
>>> Reviewed-by: Tom Rini <trini at konsulko.com>
>>> Tested-by: Lokesh Vutla <lokeshvutla at ti.com>
>>
>> This is causing build failure for the following defconfig:
>> xilinx_zynqmp_zcu104_revA_defconfig
>>
>> ➜  u-boot git:(master) v78make xilinx_zynqmp_zcu104_revA_defconfig
>>   HOSTCC  scripts/basic/fixdep
>>   HOSTCC  scripts/kconfig/conf.o
>>   YACC    scripts/kconfig/zconf.tab.c
>>   LEX     scripts/kconfig/zconf.lex.c
>>   HOSTCC  scripts/kconfig/zconf.tab.o
>> v8  HOSTLD  scripts/kconfig/conf
>> #
>> # configuration written to .config
>> #
>> ➜  u-boot git:(master) v78make -j4 -s
>> drivers/mmc/zynq_sdhci.c: In function ‘arasan_sdhci_execute_tuning’:
>> drivers/mmc/zynq_sdhci.c:97:27: error: ‘SDHCI_HOST_CTRL2’ undeclared (first use
>> in this function); did you mean ‘SDHCI_HOST_CONTROL2’?
>>   ctrl = sdhci_readw(host, SDHCI_HOST_CTRL2);
>>                            ^~~~~~~~~~~~~~~~
>>                            SDHCI_HOST_CONTROL2
>> drivers/mmc/zynq_sdhci.c:97:27: note: each undeclared identifier is reported
>> only once for each function it appears in
>> drivers/mmc/zynq_sdhci.c: In function ‘arasan_sdhci_set_control_reg’:
>> drivers/mmc/zynq_sdhci.c:182:27: error: ‘SDHCI_HOST_CTRL2’ undeclared (first use
>> in this function); did you mean ‘SDHCI_HOST_CONTROL2’?
>>    reg = sdhci_readw(host, SDHCI_HOST_CTRL2);
>>                            ^~~~~~~~~~~~~~~~
>>                            SDHCI_HOST_CONTROL2
>> drivers/mmc/zynq_sdhci.c:183:10: error: ‘SDHCI_18V_SIGNAL’ undeclared (first use
>> in this function); did you mean ‘SDHCI_DIV_HI_MASK’?
>>    reg |= SDHCI_18V_SIGNAL;
>>           ^~~~~~~~~~~~~~~~
>>           SDHCI_DIV_HI_MASK
>> scripts/Makefile.build:278: recipe for target 'drivers/mmc/zynq_sdhci.o' failed
>> make[2]: *** [drivers/mmc/zynq_sdhci.o] Error 1
>> scripts/Makefile.build:432: recipe for target 'drivers/mmc' failed
>> make[1]: *** [drivers/mmc] Error 2
>> Makefile:1582: recipe for target 'drivers' failed
>> make: *** [drivers] Error 2
>> make: *** Waiting for unfinished jobs....
>>
>>
>> Can you fix it and repost the series?
> 
> Can you re-create the issue?
> 
> Just bubbling this up to the top as it is the first series needed for TI K3
> support...
> 

Running travis on a final version. Will post soon.

Thanks,
Faiz