[U-Boot] [PATCH 1/2 v3] net: introduce MDIO DM class for MDIO devices

Alex Marginean alexm.osslist at gmail.com
Tue Jun 11 07:17:43 UTC 2019


Hi Joe,

On 6/10/2019 11:25 PM, Joe Hershberger wrote:
> On Mon, Jun 3, 2019 at 11:11 AM Alex Marginean <alexm.osslist at gmail.com> wrote:
>> Adds UCLASS_MDIO DM class supporting MDIO buses that are probed as
>> stand-alone devices.  Useful in particular for systems that support
>> DM_ETH and have a stand-alone MDIO hardware block shared by multiple
>> Ethernet interfaces.
>> Signed-off-by: Alex Marginean <alexm.osslist at gmail.com>
>> ---
>> Changes in v2:
>>          - fixed several comments using wrong API names
>>          - dropped dm_ from names of internal functions that don't use udevice *
>>          - fixed UCLASS driver name
>>          - added missing mdio_unregister in dm_mdio_pre_remove
>>          - added a comment on why spaces in names aren't ok
>>          - added a comment on how static mdio_read/_write/_reset functions
>>          are used
>> Changes in v3:
>>          - none
> Not sure if you already noticed this [1] or not, but there may be
> something there that you want to incorporate or maybe not.
> Cheers,
> -Joe
> [1] - https://patchwork.ozlabs.org/patch/939726/

I didn't notice it, thanks for pointing it out!
Apart from the obvious overlap of adding UCLASS_MDIO and code like
_post_probe they seem to deal with different needs.

Ken, can you please take a look at the patch I sent?  It has a
wrapper over phy_connect, but provides no helpers on how the caller
would get the PHY ADDR.  Do you want to try pulling the API you add on
top of the patch I sent, or do you want me to try?  It looks like it
would work with minimal effort.

Thank you!

More information about the U-Boot mailing list