[U-Boot] [PATCH v2 3/3] arm64: zynqmp: add support for Avnet UltraZed-EV Starter Kit

Luca Ceresoli luca at lucaceresoli.net
Tue Jun 11 16:09:55 UTC 2019


Hi Michal,

On 28/05/19 09:45, Michal Simek wrote:
[...]
>> +static unsigned long psu_ddr_phybringup_data(void)
>> +{
>> +	unsigned int regval = 0;
>> +	unsigned int pll_retry = 10;
>> +	unsigned int pll_locked = 0;
>> +
>> +	while ((pll_retry > 0) && (!pll_locked)) {
>> +		Xil_Out32(0xFD080004, 0x00040010);
>> +		Xil_Out32(0xFD080004, 0x00040011);
>> +
>> +		while ((Xil_In32(0xFD080030) & 0x1) != 1)
>> +			;
>> +		pll_locked = (Xil_In32(0xFD080030) & 0x80000000)
>> +		    >> 31;
>> +		pll_locked &= (Xil_In32(0xFD0807E0) & 0x10000)
>> +		    >> 16;
>> +		pll_locked &= (Xil_In32(0xFD0809E0) & 0x10000)
>> +		    >> 16;
>> +		pll_locked &= (Xil_In32(0xFD080BE0) & 0x10000)
>> +		    >> 16;
>> +		pll_locked &= (Xil_In32(0xFD080DE0) & 0x10000)
>> +		    >> 16;
>> +		pll_retry--;
>> +	}
>> +	Xil_Out32(0xFD0800C4, Xil_In32(0xFD0800C4) | (pll_retry << 16));
>> +	if (!pll_locked)
>> +		return (0);
> 
> nit: return 0;

In v3 I'm sending a new patch to let tools/zynqmp_psu_init_minimize.sh
do it automatically.

Ok for the other change requests too, will be in v3.

-- 
Luca


More information about the U-Boot mailing list