[U-Boot] [PATCH V2 2/2] watchdog: imx: Add DM support

[Heiko Schocher]

Hello Marek,

Am 11.06.2019 um 11:55 schrieb Marek Vasut:
> On 6/11/19 7:33 AM, Heiko Schocher wrote:
>> Hello Marek,
>>
>> Am 09.06.2019 um 03:46 schrieb Marek Vasut:
>>> Add DM and DT probing support to iMX watchdog driver. This should
>>> allow boards to move over to this driver, enable SYSRESET_WATCHDOG
>>> to handle cpu_reset() if required.
>>>
>>> Signed-off-by: Marek Vasut <marex at denx.de>
>>> Cc: Peng Fan <Peng.Fan at freescale.com>
>>> Cc: Stefano Babic <sbabic at denx.de>
>>> ---
>>> V2: No change
>>> ---
>>>    drivers/watchdog/Kconfig        |   2 +-
>>>    drivers/watchdog/imx_watchdog.c | 119 +++++++++++++++++++++++++++-----
>>>    2 files changed, 104 insertions(+), 17 deletions(-)
>>
>> just worked on similiar patch (not ready for mainline) ... patch looks
>> good to me, but I stumbled over a nitpick ...
>>
>> CONFIG_WATCHDOG_TIMEOUT_MSECS is defined in imx_watchdog to 128000 ms
>>
>> 37 #ifndef CONFIG_WATCHDOG_TIMEOUT_MSECS
>> 38 #define CONFIG_WATCHDOG_TIMEOUT_MSECS 128000
>> 39 #endif
>>
>> If now using DM approach it is set to 60000 ms, see include/wdt.h
>>
>> 109 #if defined(CONFIG_WDT)
>> 110 #ifndef CONFIG_WATCHDOG_TIMEOUT_MSECS
>> 111 #define CONFIG_WATCHDOG_TIMEOUT_MSECS   (60 * 1000)
>> 112 #endif
>> 113 #define WATCHDOG_TIMEOUT_SECS   (CONFIG_WATCHDOG_TIMEOUT_MSECS / 1000)
>>
>> Can you try my patch:
>> https://github.com/hsdenx/u-boot-test/commit/11503dba89cade8b81ee9d93d503d0bcce868b33
>>
>>
>> which moves WATCHDOG_TIMEOUT_MSECS to Kconfig ?
>> (Travis build just started, may not mainline ready, also patman
>>   notes in commit messages can now be removed.)
> 
> Looks good to me :)

Fine, so I rework the commit message and post it.

Thanks!

bye,
Heiko
-- 
-- 
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-52   Fax: +49-8142-66989-80   Email: hs at denx.de