[U-Boot] [PATCHv3 03/10] Kconfig: Add DEPRECATED option

[Jagan Teki]

On Wed, Jun 12, 2019 at 9:24 PM Tom Rini <trini at konsulko.com> wrote:
>
> On Wed, Jun 12, 2019 at 09:15:11PM +0530, Jagan Teki wrote:
> > On Wed, Jun 12, 2019 at 7:08 PM Tom Rini <trini at konsulko.com> wrote:
> > >
> > > On Wed, Jun 12, 2019 at 01:03:46PM +0530, Jagan Teki wrote:
> > > > On Thu, May 30, 2019 at 2:33 AM Tom Rini <trini at konsulko.com> wrote:
> > > > >
> > > > > Add a new option, CONFIG_DEPRECATED, for code that relies on deprecated
> > > > > functionality and has not been converted past the deadline for
> > > > > conversion.
> > > > >
> > > > > Signed-off-by: Tom Rini <trini at konsulko.com>
> > > > > ---
> > > > >  Kconfig | 7 +++++++
> > > > >  1 file changed, 7 insertions(+)
> > > > >
> > > > > diff --git a/Kconfig b/Kconfig
> > > > > index a02168690f5b..436308854d0c 100644
> > > > > --- a/Kconfig
> > > > > +++ b/Kconfig
> > > > > @@ -20,6 +20,13 @@ config BROKEN
> > > > >           This option cannot be enabled. It is used as dependency
> > > > >           for broken and incomplete features.
> > > > >
> > > > > +config DEPRECATED
> > > > > +       bool
> > > > > +       help
> > > > > +         This option cannot be enabled.  It it used as a dependency for
> > > > > +         code that relies on deprecated features that will be removed and
> > > > > +         the conversion deadline has passed.
> > > >
> > > > then, what would be the exact diff b/w broken vs deprecated? I do see
> > > > same meaning in terms of code maintenance, though it is working or
> > > > non-working.
> > >
> > > It is a matter of human language.  There was objection to using broken
> > > as technically the code functions (and thus is not broken) but does use
> > > deprecated APIs.
> >
> > Since broken also refer "incomplete features" in kconfig help, I
> > thought this kind of depreciated meaning will literally look similar
> > to broken. based on my experience with other opensource project like,
> > buildroot does also use broken with same meaning as broken.  Giving
> > two options of similar meaning atleast from code maintenance
> > point-of-view leads confusion to developers which is the appropriate
> > one to use. I don't see any problem of marking broken with incomplete
> > code (assuming human can treate legacy code or code would require dm
> > conversion as incomplete), giving space for another config option with
> > similar meaning doesn't worth to hold.
>
> And there is disagreement with that point of view.  Given the intention
> and use of both BROKEN and DEPRECATED, having both and using whichever
> seems better, given the normal usage of both words in english, seems
> more productive than having a thread on if "was not converted to DM by
> deadline" means "broken" or "deprecated".  I'd rather we all focus on
> converting what should get converted or pushing things along to remove
> the boards/platforms eventually that are functionally useless as they've
> had most features turned off.

OK. I have no inputs say further.

Will you take this? or shall I send the PR?