[U-Boot] [PATCH v2] watchdog: tangier: Convert to use WDT class

Stefan Roese sr at denx.de
Thu Jun 13 11:57:19 UTC 2019


On 13.06.19 13:10, Andy Shevchenko wrote:
> On Thu, Jun 13, 2019 at 06:51:34AM +0200, Stefan Roese wrote:
>> On 12.06.19 19:28, Andy Shevchenko wrote:
> 
>>>    #define WDT_DEFAULT_TIMEOUT	90
>>
>> Nitpicking: If you by any chance need to re-send this patch again,
>> please remove WDT_DEFAULT_TIMEOUT completely from this file.
> 
> This is left in order to have some traces of what firmware default is in use.
> I can convert this into comment.

Sure. You also could remove it and use this original default
value either via Kconfig (CONFIG_WATCHDOG_TIMEOUT_MSECS) or via
DT ("timeout-sec" property). All is fine with me.

Thanks,
Stefan


More information about the U-Boot mailing list