[U-Boot] [PATCH v3 2/3] fastboot: getvar: Refactor fastboot_*_get_part_info() usage

Eugeniu Rosca erosca at de.adit-jv.com
Fri Jun 14 08:41:53 UTC 2019


On Thu, Jun 13, 2019 at 09:11:08PM +0300, Sam Protsenko wrote:
[..]
> + * Get partition number and size for any storage type.
[..]
> + * @return Partition number or negative value on error
[..]

I think the word 'number' should be blacklisted in the vocabulary
of software development. It can be aliased with 'count' or 'index'
depending on context.

[1] https://marc.info/?l=linux-kernel&m=132388598809954&w=2
[2] https://patchwork.ozlabs.org/patch/1044151/#2108815

-- 
Best Regards,
Eugeniu.


More information about the U-Boot mailing list