[U-Boot] [PATCH v3] fastboot: Remove "slot-suffixes" variable

Marek Vasut marek.vasut at gmail.com
Tue Jun 18 16:31:49 UTC 2019


On 6/18/19 4:57 PM, Sam Protsenko wrote:
> Hi Marek,
> 
> As you mentioned USB PR is now open, please apply this patch in u-boot-usb.

Fastboot is gadget stuff, so that's up to Lukasz.
Is this a bugfix ?

Also, please stop top-posting.

> Thanks!
> 
> On Tue, Jun 18, 2019 at 5:55 PM Sam Protsenko
> <semen.protsenko at linaro.org> wrote:
>>
>> "slot-suffixes" variable was dropped in fastboot tool (in [1]). Let's
>> track AOSP/master and drop this variable in U-Boot as well.
>>
>> [1] https://android.googlesource.com/platform/system/core/+/42b18a518bac85c3eea14206f6cbafbd1e98a31f
>>
>> Signed-off-by: Sam Protsenko <semen.protsenko at linaro.org>
>> ---
>> Changes in v3:
>>   - rebase on top of this merged patch (v1):
>>     "[PATCH] fastboot: Fix slot names reported by getvar"
>> Changes in v2:
>>   - add this patch to patch series
>>   - drop slot-suffix variable instead of returning "a,b"
>>
>>  drivers/fastboot/fb_getvar.c | 8 --------
>>  1 file changed, 8 deletions(-)
>>
>> diff --git a/drivers/fastboot/fb_getvar.c b/drivers/fastboot/fb_getvar.c
>> index bf957e8326..c15b4f8fca 100644
>> --- a/drivers/fastboot/fb_getvar.c
>> +++ b/drivers/fastboot/fb_getvar.c
>> @@ -64,9 +64,6 @@ static const struct {
>>         }, {
>>                 .variable = "current-slot",
>>                 .dispatch = getvar_current_slot
>> -       }, {
>> -               .variable = "slot-suffixes",
>> -               .dispatch = getvar_slot_suffixes
>>  #if CONFIG_IS_ENABLED(FASTBOOT_FLASH)
>>         }, {
>>                 .variable = "has-slot",
>> @@ -182,11 +179,6 @@ static void getvar_current_slot(char *var_parameter, char *response)
>>         fastboot_okay("a", response);
>>  }
>>
>> -static void getvar_slot_suffixes(char *var_parameter, char *response)
>> -{
>> -       fastboot_okay("a,b", response);
>> -}
>> -
>>  #if CONFIG_IS_ENABLED(FASTBOOT_FLASH)
>>  static void getvar_has_slot(char *part_name, char *response)
>>  {
>> --
>> 2.20.1
>>
> _______________________________________________
> U-Boot mailing list
> U-Boot at lists.denx.de
> https://lists.denx.de/listinfo/u-boot
> 


-- 
Best regards,
Marek Vasut


More information about the U-Boot mailing list