[U-Boot] [PATCH] driver: watchdog: Add new iMX/LSCH2 WDT driver

Marek Vasut marek.vasut at gmail.com
Wed Jun 19 14:34:20 UTC 2019


On 6/19/19 6:56 AM, daniel.sangorrin at toshiba.co.jp wrote:
> Hello Robert,
> 
> I am not an expert on this, but I have been modifying a watchdog driver lately. Please check my comments below, although they may need a review from the corresponding maintainer:
> 
>> -----Original Message-----
>> From: U-Boot <u-boot-bounces at lists.denx.de> On Behalf Of Robert Hancock
>> Sent: Wednesday, June 19, 2019 12:53 AM
>> To: u-boot at lists.denx.de
>> Subject: [U-Boot] [PATCH] driver: watchdog: Add new iMX/LSCH2 WDT driver
>>
>> This is a new watchdog timer driver for iMX and LSCH2 using the WDT
>> framework and driver model. This allows ensuring that U-Boot uses the
>> same watchdog timer instance and same settings (ex: internal or external
>> reset) specified in the device tree.
>>
>> This driver can be used in preference to the old imx_watchdog driver for
>> boards which have been converted to use the driver model.
>>
>> Signed-off-by: Robert Hancock <hancock at sedsystems.ca>
>> ---
>>  drivers/watchdog/Kconfig   |  14 ++++--
>>  drivers/watchdog/Makefile  |   3 ++
>>  drivers/watchdog/imx_wdt.c | 112
> 
> Why don't you overwrite drivers/watchdog/imx_watchdog.c?
> 

Because there are still non-DM systems using it. However, I posted
patches to add DM and DT probing support for imx_watchdog, so use that.

-- 
Best regards,
Marek Vasut


More information about the U-Boot mailing list