[U-Boot] [PATCH v3 1/2] watchdog: tangier: Replace unused constant with a comment

Andy Shevchenko andriy.shevchenko at linux.intel.com
Fri Jun 21 10:28:07 UTC 2019


The default timeout value had been left in order to leave some traces
about default setup of watchdog done by firmware.

For better understanding and compiler burden, replace it with a comment.

Suggested-by: Stefan Roese <sr at denx.de>
Signed-off-by: Andy Shevchenko <andriy.shevchenko at linux.intel.com>
---
 drivers/watchdog/tangier_wdt.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/drivers/watchdog/tangier_wdt.c b/drivers/watchdog/tangier_wdt.c
index be4a8f467a..b2f40ef057 100644
--- a/drivers/watchdog/tangier_wdt.c
+++ b/drivers/watchdog/tangier_wdt.c
@@ -10,7 +10,12 @@
 #define WDT_PRETIMEOUT		15
 #define WDT_TIMEOUT_MIN		(1 + WDT_PRETIMEOUT)
 #define WDT_TIMEOUT_MAX		170
-#define WDT_DEFAULT_TIMEOUT	90
+
+/*
+ * Note, firmware chooses 90 seconds as a default timeout for watchdog on
+ * Intel Tangier SoC. It means that without handling it in the running code
+ * the reboot will happen.
+ */
 
 #ifndef CONFIG_WATCHDOG_TIMEOUT_MSECS
 #define WATCHDOG_HEARTBEAT 60000
-- 
2.20.1



More information about the U-Boot mailing list