[U-Boot] [PATCH v2] net: introduce packet capture support

[Bin Meng]

Hi Ramon,

On Fri, Jun 21, 2019 at 10:43 PM Ramon Fried <rfried.dev at gmail.com> wrote:
>
> On Fri, Jun 21, 2019 at 5:23 PM Bin Meng <bmeng.cn at gmail.com> wrote:
> >
> > Hi Ramon,
> >
> > On Fri, Jun 21, 2019 at 10:04 PM Ramon Fried <rfried.dev at gmail.com> wrote:
> > >
> > > Add support for capturing ethernet packets and storing
> > > them in memory in PCAP(2.4) format, later to be analyzed by
> > > any PCAP viewer software (IE. Wireshark)
> > >
> > > This feature greatly assist debugging network issues such
> > > as detecting dropped packets, packet corruption etc.
> > >
> > > Signed-off-by: Ramon Fried <rfried.dev at gmail.com>
> > > Reviewed-by: Alex Marginean <alexm.osslist at gmail.com>
> > > Tested-by: Alex Marginean <alexm.osslist at gmail.com>
> > > ---
> > > v2: Fix type assignmnet to header.ts_sec
> >
> > Could you please add functionality as Alex suggested? Besides what
> > Aleix mentioned, can you also add the sub-function in the pcap command
> > to store the captured packets from memory to file system?
> Sure, I started working on it, but it's a different patch

Thanks, please include all pcap related patches in a series.

> Regarding command to store it on file system, I don't think it's a wise idea,
> There's plenty of options on how to store it, not only fatwrite, it
> could be sf write, mmc write, etc.
> I think it's better to document the feature and explain the different
> options users has to store the data.

Sure, a document explaining how to use this feature is definitely helpful.

> Basically it's just typing another command.

Regards,
Bin