[U-Boot] [PATCH 1/2] regulator: Factor out common enable code

Simon Glass sjg at chromium.org
Sat Jun 22 19:10:21 UTC 2019


Hi,

On Wed, 12 Jun 2019 at 09:26, Sven Schwermer
<sven.schwermer at disruptive-technologies.com> wrote:
>
> In preparation of being able to enable/disable GPIO regulators, the
> code that will be shared among the two kinds to regulators is factored
> out into its own source files.
>
> Signed-off-by: Sven Schwermer <sven.schwermer at disruptive-technologies.com>
> ---
>  drivers/power/regulator/Kconfig            | 10 +++
>  drivers/power/regulator/Makefile           |  1 +
>  drivers/power/regulator/common-regulator.c | 80 ++++++++++++++++++++++
>  drivers/power/regulator/common-regulator.h | 27 ++++++++
>  drivers/power/regulator/fixed.c            | 75 ++------------------
>  5 files changed, 124 insertions(+), 69 deletions(-)
>  create mode 100644 drivers/power/regulator/common-regulator.c
>  create mode 100644 drivers/power/regulator/common-regulator.h

This looks fine but I think regulator_common.c (and the regulator
functions too) would be better.

Reviewed-by: Simon Glass <sjg at chromium.org>


More information about the U-Boot mailing list