[U-Boot] [EXT] Re: [PATCH v2 3/3] rtc: pcf2127: Fixed bug with rtc settings and getting error time

Chuanhua Han chuanhua.han at nxp.com
Sun Jun 23 10:40:15 UTC 2019


Hi,

> -----Original Message-----
> From: Simon Glass <sjg at chromium.org>
> Sent: 2019年6月23日 3:10
> To: Chuanhua Han <chuanhua.han at nxp.com>
> Cc: Heiko Schocher <hs at denx.de>; U-Boot Mailing List <u-boot at lists.denx.de>;
> Biwen Li <biwen.li at nxp.com>; Lukasz Majewski <lukma at denx.de>
> Subject: [EXT] Re: [PATCH v2 3/3] rtc: pcf2127: Fixed bug with rtc settings and
> getting error time
> 
> Caution: EXT Email
> 
> Hi,
> 
> On Fri, 24 May 2019 at 03:23, Chuanhua Han <chuanhua.han at nxp.com>
> wrote:
> >
> > The previous pcf2127 RTC chip could not read and set the correct time.
> > When reading the data of internal registers, the read address was the
> > value of register plus 1. This is because this chip requires the host
> > to send a stop signal after setting the register address and before
> > reading the register data.
> >
> > This patch sets the flag that the stop signal is needed and fixes the
> > bug of the original read and write time.
> >
> > Signed-off-by: Biwen Li <biwen.li at nxp.com>
> > Signed-off-by: Chuanhua Han <chuanhua.han at nxp.com>
> > ---
> > Changes in v2:
> >         - Split the original patch into 3 patches
> >         - Add detailed description information for each patch
> >
> >  drivers/rtc/pcf2127.c | 18 ++++++++++--------
> >  1 file changed, 10 insertions(+), 8 deletions(-)
> 
> Can you modify this to use i2c_xfer() so that separate transactions are done?
> 
I have sent the fourth edition you see the new patchwork:
http://patchwork.ozlabs.org/project/uboot/list/?series=114242

> Regards,
> SImon


More information about the U-Boot mailing list