[U-Boot] [PATCH 1/1] x86: Add basic Slim Bootloader payload support

[Park, Aiden]

Hi Bin,

Thanks for your feedback. I am going to make new series of split patches with proper descriptions as Simon mentioned. For Slim Bootloader support documentation, let me add README file in board/slimbootloader/slimbootloader.
By the way, it looks this patch needs to be abandoned to avoid mismatched commit number/subject. I am not sure how to deal with this in u-boot community. Can you help or give me your suggestion? Thanks in advance.

Best Regards,
Aiden

> -----Original Message-----
> From: Bin Meng [mailto:bmeng.cn at gmail.com]
> Sent: Sunday, June 23, 2019 9:55 PM
> To: Park, Aiden <aiden.park at intel.com>
> Cc: U-Boot Mailing List <u-boot at lists.denx.de>; Simon Glass
> <sjg at chromium.org>
> Subject: Re: [PATCH 1/1] x86: Add basic Slim Bootloader payload support
> 
> Hi Aiden,
> 
> On Fri, Jun 21, 2019 at 1:44 AM Park, Aiden <aiden.park at intel.com> wrote:
> >
> > This patch is to enable u-boot as a payload which runs on top of Slim
> > Bootloader(https://github.com/slimbootloader/slimbootloader)
> > boot firmware for x86 platforms.
> >
> > Added new SLIMBOOTLOADER SYS/VENDOR/TARGET CONFIG
> > - New arch/x86/cpu/slimbootloader directory with minimum codes
> > - New board/slimbootloader directory with minimum codes
> > - New dts, defconfig and configuration files
> >
> > Modified x86 files with minimum changes
> > - Kconfig and Makefile to enable new CONFIG
> > - arch_global_data structure to enable hob_list pointer
> > - init_cache_f_r to skip mtrr_commit
> >
> > Signed-off-by: Aiden Park <aiden.park at intel.com>
> 
> Thanks for the patch.
> 
> One generic comment, please split your commit into at least the following parts:
> 
> - introduce a CPU type for slimbootloader
> - add a slimbootloader specific serial DM driver into driver/serial
> - add a generic board that boots from slimbootloader (like coreboot)
> - add some documentation about slimbootloader support
> 
> > ---
> >  arch/x86/Kconfig                              |   5 +
> >  arch/x86/cpu/Makefile                         |   1 +
> >  arch/x86/cpu/slimbootloader/Kconfig           |  23 ++++
> >  arch/x86/cpu/slimbootloader/Makefile          |   5 +
> >  arch/x86/cpu/slimbootloader/car.S             |  10 ++
> >  arch/x86/cpu/slimbootloader/slimbootloader.c  | 117 ++++++++++++++++++
> >  .../cpu/slimbootloader/slimbootloader_hob.c   |  67 ++++++++++
> >  .../slimbootloader/slimbootloader_serial.c    |  66 ++++++++++
> >  arch/x86/dts/Makefile                         |   3 +-
> >  arch/x86/dts/slimbootloader.dts               |  33 +++++
> >  .../asm/arch-slimbootloader/slimbootloader.h  |  78 ++++++++++++
> >  arch/x86/include/asm/global_data.h            |   2 +-
> >  arch/x86/lib/asm-offsets.c                    |   2 +-
> >  arch/x86/lib/init_helpers.c                   |   2 +-
> >  board/slimbootloader/Kconfig                  |  21 ++++
> >  board/slimbootloader/slimbootloader/Kconfig   |  51 ++++++++
> >  board/slimbootloader/slimbootloader/Makefile  |   5 +
> >  .../slimbootloader/slimbootloader.c           |  60 +++++++++
> >  .../slimbootloader/slimbootloader_start.S     |  31 +++++
> >  configs/slimbootloader_defconfig              |  64 ++++++++++
> >  include/configs/slimbootloader.h              |  54 ++++++++
> >  21 files changed, 696 insertions(+), 4 deletions(-)  create mode
> > 100644 arch/x86/cpu/slimbootloader/Kconfig
> >  create mode 100644 arch/x86/cpu/slimbootloader/Makefile
> >  create mode 100644 arch/x86/cpu/slimbootloader/car.S  create mode
> > 100644 arch/x86/cpu/slimbootloader/slimbootloader.c
> >  create mode 100644 arch/x86/cpu/slimbootloader/slimbootloader_hob.c
> >  create mode 100644
> > arch/x86/cpu/slimbootloader/slimbootloader_serial.c
> >  create mode 100644 arch/x86/dts/slimbootloader.dts  create mode
> > 100644 arch/x86/include/asm/arch-slimbootloader/slimbootloader.h
> >  create mode 100644 board/slimbootloader/Kconfig  create mode 100644
> > board/slimbootloader/slimbootloader/Kconfig
> >  create mode 100644 board/slimbootloader/slimbootloader/Makefile
> >  create mode 100644
> > board/slimbootloader/slimbootloader/slimbootloader.c
> >  create mode 100644
> > board/slimbootloader/slimbootloader/slimbootloader_start.S
> >  create mode 100644 configs/slimbootloader_defconfig  create mode
> > 100644 include/configs/slimbootloader.h
> >
> 
> I will take a further look once the patch division is done. Thanks!
> 
> Regards,
> Bin