[U-Boot] [PATCH 1/1] trace: do not limit trace buffer to 2GiB

[Simon Glass]

Hi Heinrich,

On Sat, 22 Jun 2019 at 20:37, Heinrich Schuchardt <xypron.glpk at gmx.de> wrote:
>
> On 6/22/19 9:10 PM, Simon Glass wrote:
> > On Fri, 14 Jun 2019 at 20:51, Heinrich Schuchardt <xypron.glpk at gmx.de> wrote:
> >>
> >> There is no good reason to limit the trace buffer to 2GiB on a 64bit
> >> system. Adjust the types of the relevant parameters.
> >>
> >> Signed-off-by: Heinrich Schuchardt <xypron.glpk at gmx.de>
> >> ---
> >>   cmd/trace.c      | 10 ++++------
> >>   include/trace.h  |  6 +++---
> >>   lib/trace.c      | 14 +++++++-------
> >>   tools/proftool.c |  4 ++--
> >>   4 files changed, 16 insertions(+), 18 deletions(-)
> >
> > Wow it's going to take a very long time to transfer that much data
> > over your network.
>
> Thanks for reviewing.
>
> I am writing files with the traces to the mounted file system.
>
> I activated traces in lib/efi_loader only and found several hundred
> thousand function calls just to start Shell.efi which ended up in
> exceeding the trace buffer. This is why want to lift unnecessary
> restrictions.
>
> What I still need to write is a script to analyze the traces to
> calculate the gross and the net time spent in each function.

OK I see, sounds good. Also, I suppose you saw that you can use
pytimechart to view the data, as in README.trace


- Simon