[U-Boot] QSPI support on i.MX7D Sabre Eval Board

Fabio Estevam festevam at gmail.com
Mon Jun 24 15:57:01 UTC 2019


Hi Thomas,

On Mon, Jun 24, 2019 at 12:47 PM Thomas Schaefer
<Thomas.Schaefer at kontron.com> wrote:

> Following Fabio's suggestion I have prepared the following patch that fixes the QSPI read support issue of the fsl_qspi driver on my i.MX7D Sabre eval system. Could you please review/check this patch and introduce it into upcoming v2019.07 version?
>
> Thanks, Thomas
>
>
> From: Thomas Schaefer <thomas.schaefer at kontron.com>
> Date: Mon, 24 Jun 2019 17:15:57 +0200
> Subject: [PATCH] driver/spi: fsl_qspi: fix is_controller_busy check
>
> Use readl_poll_timeout function to check for busy controller with
> a timeout of 1000 us instead of 5 fixed test loops.
>
> Signed-off-by: Thomas Schaefer <thomas.schaefer at kontron.com>

I think the change looks good, but I suggest to improve the commit log
by stating that with the current code you observe timeout during QSPI
read.

Please submit it as formal patch.

Thanks


More information about the U-Boot mailing list