[U-Boot] [PATCH 1/2] usb: kbd: simplify coding for arrow keys

Heinrich Schuchardt xypron.glpk at gmx.de
Mon Jun 24 17:36:37 UTC 2019


On 6/24/19 3:56 PM, Simon Glass wrote:
> On Sun, 16 Jun 2019 at 22:44, Heinrich Schuchardt <xypron.glpk at gmx.de> wrote:
>>
>> Avoid duplicate translation of arrow key codes.
>>
>> Signed-off-by: Heinrich Schuchardt <xypron.glpk at gmx.de>
>> ---
>>   common/usb_kbd.c | 31 +++++++++----------------------
>>   1 file changed, 9 insertions(+), 22 deletions(-)
>
> Reviewed-by: Simon Glass <sjg at chromium.org>
>
> We should really have a test for this input stuff...
>

We already have.

For low level analysis:

=> conitrace
Waiting for your input
To terminate type 'x'
61
1b 5b 32 30 7e

For a higher level view:

=> setenv efi_selftest extended text input
=> bootefi selftest
Executing 'extended text input'
Waiting for your input
To terminate type 'CTRL+x'
Unicode char 100 ('d'), scan code 0 (Null)
Unicode char 0 (Null), scan code 19 (+FN 9)
Unicode char 0 (Null), scan code 19 (SHIFT+FN 9)

Regards

Heinrich


More information about the U-Boot mailing list